From ad410b963369ec6b55526401c3873e6076b18b5f Mon Sep 17 00:00:00 2001 From: erdgeist Date: Thu, 30 Jul 2026 13:43:26 +0200 Subject: Retire the unroutable scaffold views Nine generator leftovers for actions that either do not exist or never render HTML. menu_items/show goes with its route and its action, since deleting the template alone would turn a dead page into a missing-template error; pages_controller has only #preview, so its four CRUD views were unreachable by any route; and nodes#update redirects on every path. --- app/controllers/menu_items_controller.rb | 3 --- app/views/menu_items/create.html.erb | 2 -- app/views/menu_items/delete.html.erb | 2 -- app/views/menu_items/show.html.erb | 2 -- app/views/menu_items/update.html.erb | 2 -- app/views/nodes/update.html.erb | 2 -- app/views/pages/edit.html.erb | 24 ------------------------ app/views/pages/index.html.erb | 24 ------------------------ app/views/pages/new.html.erb | 31 ------------------------------- app/views/pages/show.html.erb | 28 ---------------------------- 10 files changed, 120 deletions(-) delete mode 100644 app/views/menu_items/create.html.erb delete mode 100644 app/views/menu_items/delete.html.erb delete mode 100644 app/views/menu_items/show.html.erb delete mode 100644 app/views/menu_items/update.html.erb delete mode 100644 app/views/nodes/update.html.erb delete mode 100644 app/views/pages/edit.html.erb delete mode 100644 app/views/pages/index.html.erb delete mode 100644 app/views/pages/new.html.erb delete mode 100644 app/views/pages/show.html.erb (limited to 'app') diff --git a/app/controllers/menu_items_controller.rb b/app/controllers/menu_items_controller.rb index 8b4e636e..48018800 100644 --- a/app/controllers/menu_items_controller.rb +++ b/app/controllers/menu_items_controller.rb @@ -11,9 +11,6 @@ class MenuItemsController < ApplicationController @menu_items = MenuItem.order("position ASC").all end - def show - end - def new @menu_item = MenuItem.new end diff --git a/app/views/menu_items/create.html.erb b/app/views/menu_items/create.html.erb deleted file mode 100644 index 023f7b9a..00000000 --- a/app/views/menu_items/create.html.erb +++ /dev/null @@ -1,2 +0,0 @@ -

MenuItems#create

-

Find me in app/views/menu_items/create.html.erb

diff --git a/app/views/menu_items/delete.html.erb b/app/views/menu_items/delete.html.erb deleted file mode 100644 index 762b16ef..00000000 --- a/app/views/menu_items/delete.html.erb +++ /dev/null @@ -1,2 +0,0 @@ -

MenuItems#delete

-

Find me in app/views/menu_items/delete.html.erb

diff --git a/app/views/menu_items/show.html.erb b/app/views/menu_items/show.html.erb deleted file mode 100644 index 65f9ef19..00000000 --- a/app/views/menu_items/show.html.erb +++ /dev/null @@ -1,2 +0,0 @@ -

MenuItems#show

-

Find me in app/views/menu_items/show.html.erb

diff --git a/app/views/menu_items/update.html.erb b/app/views/menu_items/update.html.erb deleted file mode 100644 index 3df2a43d..00000000 --- a/app/views/menu_items/update.html.erb +++ /dev/null @@ -1,2 +0,0 @@ -

MenuItems#update

-

Find me in app/views/menu_items/update.html.erb

diff --git a/app/views/nodes/update.html.erb b/app/views/nodes/update.html.erb deleted file mode 100644 index 5c6caa8d..00000000 --- a/app/views/nodes/update.html.erb +++ /dev/null @@ -1,2 +0,0 @@ -

Nodes#update

-

Find me in app/views/nodes/update.html.erb

diff --git a/app/views/pages/edit.html.erb b/app/views/pages/edit.html.erb deleted file mode 100644 index 8b1242cc..00000000 --- a/app/views/pages/edit.html.erb +++ /dev/null @@ -1,24 +0,0 @@ -

Editing page

- -<%= form_for(@page) do |f| %> - <%= form_error_messages(f) %> - -

- <%= f.label :title %>
- <%= f.text_field :title %> -

-

- <%= f.label :abstract %>
- <%= f.text_area :abstract %> -

-

- <%= f.label :body %>
- <%= f.text_area :body %> -

-

- <%= f.submit "Update" %> -

-<% end %> - -<%= link_to 'Show', @page %> | -<%= link_to 'Back', pages_path %> diff --git a/app/views/pages/index.html.erb b/app/views/pages/index.html.erb deleted file mode 100644 index da67871c..00000000 --- a/app/views/pages/index.html.erb +++ /dev/null @@ -1,24 +0,0 @@ -

Pages

- - - - - - - -<% for page in @pages %> - - - - - - - -<% end %> -
NodeTitle
<%=h page.node_id %><%=h page.title %><%= link_to 'Show', content_path(:page_path => page.node.unique_path) %><%= link_to 'Edit', edit_page_path(page) %><%= button_to page, method: :delete, form: { data: { confirm: 'Are you sure?' }, class: 'button_to destructive' } do %> - <%= icon("trash", library: "tabler", "aria-hidden": true) %> Destroy - <% end %>
- -
- -<%= link_to 'New page', new_page_path %> diff --git a/app/views/pages/new.html.erb b/app/views/pages/new.html.erb deleted file mode 100644 index 2758faf5..00000000 --- a/app/views/pages/new.html.erb +++ /dev/null @@ -1,31 +0,0 @@ -

New page

- -<%= form_for(@page) do |f| %> - <%= form_error_messages(f) %> - -

- <%= f.label :node_id %>
- <%= f.text_field :node_id %> -

-

- <%= f.label :title %>
- <%= f.text_field :title %> -

-

- <%= f.label :abstract %>
- <%= f.text_area :abstract %> -

-

- <%= f.label :body %>
- <%= f.text_area :body %> -

-

- <%= f.label :revision %>
- <%= f.text_field :revision %> -

-

- <%= f.submit "Create" %> -

-<% end %> - -<%= link_to 'Back', pages_path %> diff --git a/app/views/pages/show.html.erb b/app/views/pages/show.html.erb deleted file mode 100644 index 254b9406..00000000 --- a/app/views/pages/show.html.erb +++ /dev/null @@ -1,28 +0,0 @@ -

- Node: - <%=h @page.node_id %> -

- -

- Title: - <%=h @page.title %> -

- -

- Abstract: - <%=h @page.abstract %> -

- -

- Body: - <%=h @page.body %> -

- -

- Revision: - <%=h @page.revision %> -

- - -<%= link_to 'Edit', edit_page_path(@page) %> | -<%= link_to 'Back', pages_path %> -- cgit v1.3