summaryrefslogtreecommitdiff
path: root/app/controllers/nodes_controller.rb
AgeCommit message (Collapse)Author
4 daysStage 7 click-testing fixes (2)erdgeist
- nodes_controller: permit staged_slug and staged_parent_id in node params; these were silently dropped since strong parameters migration, breaking the two-phase slug/parent change workflow - file_attachment: add SVG support; vector files are copied to all style directories without rasterisation, preserving scalability in the browser - assets index/show: constrain image display with max-width/max-height via admin.css td img rule; fixes oversized SVG thumbnails while leaving raster variants unaffected
6 daysStage 4: Rails 5.2 -> 6.1 on Ruby 2.7.2erdgeist
- routing-filter 0.6.3 -> 0.7.0 (Rails 6.1 compatibility) - RSS named routes rss_xml/rss_rdf added - RouteWithParams workarounds: will_paginate_patch, content_path shim, safe_path helper - Paperclip removed, replaced with FileAttachment concern (preserves URL scheme) - Assets resource moved to /admin/assets (Sprockets middleware conflict) - ApplicationRecord base class added, all models migrated - Strong parameters added to Assets, Occurrences, Events, MenuItems controllers - update_attributes -> update throughout - render :nothing -> head :ok/:not_found throughout - language_selector rewritten (removes :overwrite_params) - Environment files updated for Rails 6.1 (eager_load, public_file_server, ActionMailer) - Arel::Visitors::DepthFirst and Integer/Float duration patches removed from test_helper - AssetsController tests added (10 tests covering upload, variants, destroy, auth) - ImageMagick geometry: 460x250! for headline crop (not # which is invalid in IM6) 129 runs, 311 assertions, 5 failures (all pre-existing), 0 errors
6 daysRails 5.2 application fixeserdgeist
- Rename before_filter → before_action across all controllers - Fix string conditions in validators to lambda syntax (node.rb) - Fix publish_draft!: move staged slug/parent logic outside draft guard, use move_to_child_of for parent changes, add nil guard for no-op calls - Fix update_unique_names_of_children: use parent_id traversal instead of lft/rgt descendants (awesome_nested_set 3.x lft/rgt update bug) - Fix unique_path to return Array instead of String - Fix Occurrence.delete_all syntax for Rails 5 - Fix Page.find_with_outdated_translations: use includes instead of all - Fix outdated_translations?: use find instead of splat array
7 daysRails 4.2 model and controller fixeserdgeist
- Wrap all scopes in lambdas (required in Rails 4) - Move scopes after associations in page.rb (evaluated at load time in Rails 4) - Convert association :order options to lambda syntax - Remove attr_accessible from page.rb and user.rb - Add Strong Parameters: user_params in UsersController, node_params/page_params in NodesController - Fix clone_attributes_from: exclude id/page_id/timestamps when cloning translations - Fix redirect_to :back → request.referer fallback in nodes_controller - Fix node_path/publish and unlock actions: pass @node argument
8 daysStage 1 complete: Rails 2.3.5 to Rails 3.2.22.5 upgradeerdgeist
- Converted plugins to gems (Gemfile) - Updated config structure (application.rb, boot.rb, environment.rb) - Converted routes to Rails 3 DSL - Converted named_scope to scope throughout models - Converted find(:all, :conditions) to where() chains - Fixed has_many :order to use ordering scope - Updated session store and secret token configuration - Fixed exception_notification middleware configuration - Patched Ruby 2.4 / Rails 3.2 incompatibilities: - Integer/Float duration arithmetic (ActiveSupport) - Arel visit_Integer for PostgreSQL adapter - create_database String/Integer coercion - ActionController consider_all_requests_local - Migrated taggings schema for acts-as-taggable-on - Replaced dynamic_form gem with custom form_error_messages helper - Fixed Rails 3 block helper syntax (form_for, form_tag, fields_for) - Fixed admin layout yield - Updated test suite for Rails 3 APIs
8 daysUpdate deployed state to what's currently runningerdgeist
2025-02-06Improve worklflowerdgeist
2009-10-17changed some node related methods and implementation of unlockhukl
2009-09-12changed the ui click flow a bithukl
2009-09-11enhanced LockedByAnotherUser exception which now includes a message showing the last modified time.hukl
Closes #13
2009-09-10going back to raisl 2.3.3 as 2.3.4 has weird issues when translationg active record validation errorshukl
also changing the german error messages to english as the interface is english only so far
2009-09-10forgot to remove the breakpoint herehukl
2009-09-10refactored the create method to actually produce meaningful error messages when something goes wrong. added tests for corner caseshukl
2009-09-09added editing of slugs and moving of nodes. to edit a slug or move a node you edit that node, make your changes and save. the slug and parent node changes ↵hukl
get staged and are applied once that revision is published
2009-09-08lots of gui improvements for creating nodeshukl
2009-09-06Marked Controllers private / public and added authorization filters accordinglyhukl
2009-09-03more graceful handling of locked pages exceptions.hukl
2009-06-13added js search widget with clickable results that will take the user to the brand new "show" version of the page. so the user doesn't create new revisions ↵hukl
and locks all the time when he / she only wants to take a look at it.
2009-05-01always render a previewhukl
2009-04-19fix for renamed methodhukl
2009-04-16added autosave to node edit view. saves every 15 secondshukl
2009-03-22Finally! The cloning of pages for creating new drafts is now a lot cleaner. I had to search for a while to figure out a better way. Thank you svenfuchs and ↵hukl
joshmh for the support!
2009-03-21small changehukl
2009-03-09after creating a node, edit it rather than showing ithukl
2009-03-08added basic preview feature. If a draft exists, the show action renders a proper preview. If not the default show template is rendered.hukl
2009-03-02added unlock functionality. not yet hooked up with permissions though. anybody can unlock. put a confirmation in front of it. destroy has to be confirmed as ↵hukl
well
2009-03-01refactored drafts which are now identified by a draft_id on the node rather than by guessing it. i was really that close to make that mistake again.hukl
2009-02-26the locale stuff as well as the cloning should work now entirely as expected although the cloning itself isn't really a beautyhukl
2009-02-24small modification with a big workflow impact!hukl
2009-02-22replaced freeform textfield with select tag which has to be replaced with something more decent soon. but it works for nowhukl
2009-02-22another round of view updateshukl
2009-02-22lots of view improvements - not ready thoughhukl
2009-02-21wiring together some views to make basic navigationhukl
in the admin interface possible
2009-02-21adding @node filter for publish action and settinghukl
a new member route for the nodes resource so that a put request on /nodes/id/publish will publish the current draft of a node
2009-02-21added before_filter :login_requiredhukl
2009-02-17changed index action to use pagination. avoiding ahukl
tree for now
2009-02-15using real users now that we have a real user modelhukl
2009-02-15more nodes controller functionalityhukl
2009-02-15* removed the auditing observer, we'll do it the old fashioned waysimon
* added permission model * locked down attributes on page model
2009-02-15* mergin stuff yo, why do i have to do this again?simon
2009-02-15* here comes da wicked sick auditing observer hacksimon
2009-02-15brace for impactsimon
oh god, oh god, we're all going to die ...
2009-02-15added implementation details for nodeshukl
2009-02-13tiny change for future user modelhukl
2009-02-08added nodes controller and made it a resource.hukl
since the node is the proxy for the pages behind it, it makes sense to operate on nodes rather than on the pages themselves.