From 4596b32a0787a574881284d042bb77c970df8a4d Mon Sep 17 00:00:00 2001 From: erdgeist Date: Sat, 4 Jul 2026 01:25:24 +0200 Subject: Fix safe_return_to being uncallable from controllers Defined only in ApplicationHelper, which Rails auto-mixes into views but not controllers - so events#create and events#update, which call it directly, have been broken since introduction. Likely unexercised until now because every existing event was created via node.events.create! in the seed script, never through a real POST. Moved to ApplicationController as a protected method + helper_method declaration, so both controllers and views can call it (form_error_ messages stays in ApplicationHelper - it's genuinely view-only, content_tag isn't available in a controller either). Logic unchanged, caught by the new EventsController tests in the previous commit. --- app/helpers/application_helper.rb | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'app/helpers') diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 72b76b8..0be66e9 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -11,14 +11,4 @@ module ApplicationHelper end end end - - def safe_return_to(url) - return events_path if url.blank? - uri = URI.parse(url) - return events_path if uri.host.present? - return events_path unless url.start_with?('/') - url - rescue URI::InvalidURIError - events_path - end end -- cgit v1.3