From 1bf719d6ac58187cf406d92a40b665d3fa6e658b Mon Sep 17 00:00:00 2001
From: erdgeist <erdgeist@erdgeist.org>
Date: Tue, 7 Jul 2026 03:48:09 +0200
Subject: Add context-aware child-creation shortcuts to nodes#show

parent_match Procs on CccConventions::NODE_KINDS, matched against
unique_path, decide which "add child" kinds show on a given node. Fixes
nodes#new not honoring a pre-selected kind (radio group and parent-field
visibility both defaulted to "generic" unconditionally).
---
 lib/ccc_conventions.rb | 61 +++++++++++++++++++++++++++-----------------------
 1 file changed, 33 insertions(+), 28 deletions(-)

(limited to 'lib')

diff --git a/lib/ccc_conventions.rb b/lib/ccc_conventions.rb
index c0f9943..b420452 100644
--- a/lib/ccc_conventions.rb
+++ b/lib/ccc_conventions.rb
@@ -4,44 +4,49 @@ module CccConventions
 
   NODE_KINDS = {
     "top_level" => {
-      parent:      -> { Node.root },
-      path_prefix: "",
-      label:       "Top Level"
+      parent:       -> { Node.root },
+      parent_match: ->(path) { path == [] },
+      path_prefix:  "",
+      label:        "Top Level"
     },
     "generic" => {
-      label: "Generic",
-      hint:  "Can be created anywhere - choose the parent below."
-      # no path_prefix - depends on whatever parent gets chosen; see below
+      parent_match: ->(path) { true },
+      label:        "Generic",
+      hint:         "Can be created anywhere - choose the parent below."
     },
     "update" => {
-      parent:      -> { Update.find_or_create_parent },
-      tags:        ["update"],
-      path_prefix: -> { "updates/#{Time.now.year}" },
-      label:       "Update",
-      hint:        -> { "Automatically created in /updates/#{Time.now.year}/, gets tag \"update\", and inherits the update template." }
+      parent:       -> { Update.find_or_create_parent },
+      parent_match: ->(path) { path[0] == "updates" && (path.length == 1 || path[1] =~ /\A\d{4}\z/) },
+      tags:         ["update"],
+      path_prefix:  -> { "updates/#{Time.now.year}" },
+      label:        "Update",
+      hint:         -> { "Automatically created in /updates/#{Time.now.year}/, gets tag \"update\", and inherits the update template." }
     },
     "press_release" => {
-      parent:      -> { Update.find_or_create_parent },
-      tags:        ["update", "pressemitteilung"],
-      path_prefix: -> { "updates/#{Time.now.year}" },
-      label:       "Pressemitteilung",
-      hint:        -> { "Automatically created in /updates/#{Time.now.year}/, gets tags \"update, pressemitteilung\", and inherits the update template." }
+      parent:       -> { Update.find_or_create_parent },
+      parent_match: ->(path) { path[0] == "updates" && (path.length == 1 || path[1] =~ /\A\d{4}\z/) },
+      tags:         ["update", "pressemitteilung"],
+      path_prefix:  -> { "updates/#{Time.now.year}" },
+      label:        "Pressemitteilung",
+      hint:         -> { "Automatically created in /updates/#{Time.now.year}/, gets tags \"update, pressemitteilung\", and inherits the update template." }
     },
     "erfa" => {
-      parent:      -> { Node.find_by_unique_name!(ERFA_PARENT_NAME) },
-      tags:        ["erfa-detail"],
-      template:    "chapter_detail",
-      path_prefix: ERFA_PARENT_NAME,
-      label:       "Erfa",
-      hint:        "Automatically created under the Erfa-Kreise overview page, gets tag \"erfa-detail\", and uses the chapter detail template."
+      parent:       -> { Node.find_by_unique_name!(ERFA_PARENT_NAME) },
+      parent_match: ->(path) { path == ["club", "erfas"] },
+      tags:         ["erfa-detail"],
+      template:     "chapter_detail",
+      path_prefix:  ERFA_PARENT_NAME,
+      label:        "Erfa",
+      hint:         "Automatically created under the Erfa-Kreise overview page, gets tag \"erfa-detail\", and uses the chapter detail template."
     },
     "chaostreff" => {
-      parent:      -> { Node.find_by_unique_name!(CHAOSTREFF_PARENT_NAME) },
-      tags:        ["chaostreff-detail"],
-      template:    "chapter_detail",
-      path_prefix: CHAOSTREFF_PARENT_NAME,
-      label:       "Chaostreff",
-      hint:        "Automatically created under the Chaostreffs overview page, gets tag \"chaostreff-detail\", and uses the chapter detail template."
+      parent:       -> { Node.find_by_unique_name!(CHAOSTREFF_PARENT_NAME) },
+      parent_match: ->(path) { path == ["club", "chaostreffs"] },
+      tags:         ["chaostreff-detail"],
+      template:     "chapter_detail",
+      path_prefix:  CHAOSTREFF_PARENT_NAME,
+      label:        "Chaostreff",
+      hint:         "Automatically created under the Chaostreffs overview page, gets tag \"chaostreff-detail\", and uses the chapter detail template."
     }
   }.freeze
 end
-- 
cgit v1.3