From 40adeec1bcc6fa276d765e3b9c37e781c64a48c1 Mon Sep 17 00:00:00 2001 From: erdgeist Date: Mon, 13 Jul 2026 17:09:45 +0200 Subject: Fix shared preview redirecting to admin for an ordinary new draft superseded/currently_public used published_at presence as a proxy for page-row relevance, but published_at is carried forward onto every new draft descended from previously-published content (Page#clone_attributes_from, Node#save_draft!) -- so it read true for any draft on an already-published node, whether or not that specific draft had ever gone live itself. Compare draft_id/head_id identity directly instead; no timestamp involved. A stale (superseded) link now redirects to the live public page rather than an admin URL an anonymous holder can't reach anyway. --- .../controllers/shared_previews_controller_test.rb | 35 ++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 test/controllers/shared_previews_controller_test.rb (limited to 'test/controllers/shared_previews_controller_test.rb') diff --git a/test/controllers/shared_previews_controller_test.rb b/test/controllers/shared_previews_controller_test.rb new file mode 100644 index 0000000..5f2d20d --- /dev/null +++ b/test/controllers/shared_previews_controller_test.rb @@ -0,0 +1,35 @@ +require 'test_helper' + +class SharedPreviewsControllerTest < ActionController::TestCase + test "renders the preview for a draft that is current but not yet head" do + node = Node.root.children.create!(:slug => "shared_preview_draft_test") + node.draft.ensure_preview_token! + + get :show, params: { :token => node.draft.preview_token } + + assert_response :success + end + + test "renders the preview for a brand-new draft on an already-published node" do + node = Node.root.children.create!(:slug => "shared_preview_published_node_test") + node.publish_draft! + node.find_or_create_draft(User.first) + node.draft.ensure_preview_token! + + get :show, params: { :token => node.draft.preview_token } + + assert_response :success + end + + test "redirects to the live page once the previewed draft has been published and become head" do + node = Node.root.children.create!(:slug => "shared_preview_now_head_test") + node.draft.ensure_preview_token! + token = node.draft.preview_token + + node.publish_draft! + + get :show, params: { :token => token } + + assert_redirected_to node.head.public_link + end +end -- cgit v1.3