From 836308471f8d31ccdcdd3a5bd88bc76cc1c0831b Mon Sep 17 00:00:00 2001 From: erdgeist Date: Mon, 20 Jul 2026 19:45:43 +0200 Subject: Make headline images explicit, add asset credits - related_assets gains a `headline` boolean (DB-enforced: at most one per page), replacing "first image by position" as the headline rule. A rake task backfills the current first image on every live head/draft, so nothing changes visually until an editor changes it. - The image picker sidebar gets a star toggle reflecting the flag; the TinyMCE inline-image picker's badge now reads it too, instead of assuming position 0. - No headline chosen (or none attached) now falls back to the gallery-count caption itself becoming the lightbox trigger, instead of the gallery being unreachable. - Assets gain creator, source_url, and license_key (against a new config/asset_licenses.yml dictionary). asset_credit renders a degrading attribution line, reused as a hidden per-image glightbox caption so credit is one click away for every image, not only the headline's always-visible one. - Fixed: asset thumbnails rendered unconditionally regardless of whether a real variant exists on disk. Asset#has_variant? checks file existence, not content type -- some legacy PDFs have real pre-rewrite thumbnails a content-type check would have hidden. - assets#new/edit rebuilt onto the same node_description/node_content layout as assets#show, picking up the three new fields in the process. --- test/controllers/related_assets_controller_test.rb | 46 ++++++++++++++++++++++ 1 file changed, 46 insertions(+) (limited to 'test/controllers') diff --git a/test/controllers/related_assets_controller_test.rb b/test/controllers/related_assets_controller_test.rb index 9d20cbb..2384adc 100644 --- a/test/controllers/related_assets_controller_test.rb +++ b/test/controllers/related_assets_controller_test.rb @@ -88,4 +88,50 @@ class RelatedAssetsControllerTest < ActionController::TestCase ordered_asset_ids = node.draft.reload.related_assets.map(&:asset_id) assert_equal [second.id, first.id], ordered_asset_ids end + + test "update sets the headline flag" do + login_as :quentin + node = Node.root.children.create!(:slug => "related_assets_headline_test") + asset = Asset.create!(:name => "headline-photo", :upload_content_type => "image/png") + node.draft.assets << asset + related = node.draft.related_assets.find_by(:asset_id => asset.id) + + patch :update, params: { :node_id => node.id, :id => related.id, :headline => "true" } + + assert_response :success + assert related.reload.headline? + end + + test "update with headline=true clears any previous headline on the same page" do + login_as :quentin + node = Node.root.children.create!(:slug => "related_assets_headline_swap_test") + first = Asset.create!(:name => "first-headline", :upload_content_type => "image/png") + second = Asset.create!(:name => "second-headline", :upload_content_type => "image/png") + node.draft.assets << first + node.draft.assets << second + + first_related = node.draft.related_assets.find_by(:asset_id => first.id) + second_related = node.draft.related_assets.find_by(:asset_id => second.id) + first_related.update!(:headline => true) + + patch :update, params: { :node_id => node.id, :id => second_related.id, :headline => "true" } + + assert_response :success + assert_not first_related.reload.headline? + assert second_related.reload.headline? + end + + test "update with headline=false clears the headline" do + login_as :quentin + node = Node.root.children.create!(:slug => "related_assets_headline_unset_test") + asset = Asset.create!(:name => "unset-headline", :upload_content_type => "image/png") + node.draft.assets << asset + related = node.draft.related_assets.find_by(:asset_id => asset.id) + related.update!(:headline => true) + + patch :update, params: { :node_id => node.id, :id => related.id, :headline => "false" } + + assert_response :success + assert_not related.reload.headline? + end end -- cgit v1.3