From d56155231814633e04f856d22646fea24ef97011 Mon Sep 17 00:00:00 2001 From: erdgeist Date: Wed, 15 Jul 2026 01:41:34 +0200 Subject: Add NodeAction: an append-only log of who did what to a node node_id/page_id/user_id are lookup and ordering only -- all three nullify on delete, so an entry outlives its actor and its subject. Everything that must survive those deletions lives in a mandatory metadata jsonb written once at creation: the actor's username, the node's human-readable name (pinned to the default locale), and action-specific extras such as publish's title from/to. NodeAction.record! is the single constructor, so every entry gets the same baseline metadata without each call site re-implementing it. occurred_at is one field for live and backfilled entries alike; inferred_from distinguishes them -- nil means witnessed at the moment it happened, populated names how a backfilled entry was estimated. Instrumented so far: publish (crediting the actual publisher, threaded through from the controller -- previously nobody had the act of publishing recorded anywhere), revert's discard_autosave and destroy_draft branches, and translation destroy. publish_draft! now runs in a transaction so the promotion and its log entry land together. The remaining verbs follow once this mechanism has proven itself. --- test/controllers/page_translations_controller_test.rb | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'test/controllers') diff --git a/test/controllers/page_translations_controller_test.rb b/test/controllers/page_translations_controller_test.rb index 8fa732f..82f8bce 100644 --- a/test/controllers/page_translations_controller_test.rb +++ b/test/controllers/page_translations_controller_test.rb @@ -82,4 +82,19 @@ class PageTranslationsControllerTest < ActionController::TestCase assert_equal page_count_before, node.pages.count assert_equal "in progress", Globalize.with_locale(:en) { node.autosave.title } end + + test "destroy logs a translation_destroy NodeAction" do + login_as :quentin + node = Node.root.children.create!(:slug => "translation_destroy_log_test") + Globalize.with_locale(:en) { node.draft.update!(:title => "English title") } + + delete :destroy, params: { :node_id => node.id, :translation_locale => "en" } + + action = NodeAction.last + assert_equal node, action.node + assert_equal "en", action.locale + assert_equal "translation_destroy", action.action + assert_equal users(:quentin), action.user + assert_redirected_to node_path(node) + end end -- cgit v1.3