Check rendered markup for balance in controller tests

Every successful HTML response is parsed, as a document or a fragment
depending on whether it carries a doctype, and parse errors fail the test.

New actions inherit the check.

1 files changed, 21 insertions, 0 deletions

diff --git a/test/test_helper.rb b/test/test_helper.rb
index b7fe2b58..ec9b18b3 100644
--- a/test/test_helper.rb
+++ b/test/test_helper.rb
@@ -78,4 +78,25 @@ class ActiveSupport::TestCase
     node.lock_for_editing!(user)
     node.draft || node.create_new_draft(user)
   end
+
+  def assert_well_formed
+    body = @response.body
+    doc = if body.lstrip.start_with?("<!DOCTYPE", "<html")
+            Nokogiri::HTML5(body, max_errors: -1)
+          else
+            Nokogiri::HTML5.fragment(body, max_errors: -1)
+          end
+    assert_empty doc.errors,
+      "Malformed markup:\n#{doc.errors.map(&:to_s).join("\n")}"
+  end
+end
+
+class ActionController::TestCase
+  def process(*args, **kwargs)
+    super.tap do
+      if @response&.successful? && @response.media_type == "text/html"
+        assert_well_formed
+      end
+    end
+  end
 end