diff options
| author | erdgeist <erdgeist@erdgeist.org> | 2026-07-30 13:43:26 +0200 |
|---|---|---|
| committer | erdgeist <erdgeist@erdgeist.org> | 2026-07-30 13:43:26 +0200 |
| commit | ad410b963369ec6b55526401c3873e6076b18b5f (patch) | |
| tree | bbf3bef14e0646c7db212274dc3e656771881659 | |
| parent | 5ef13e5aa5ea565b07441616ab1eece565aa2f53 (diff) | |
Retire the unroutable scaffold views
Nine generator leftovers for actions that either do not exist or never
render HTML. menu_items/show goes with its route and its action, since
deleting the template alone would turn a dead page into a missing-template
error; pages_controller has only #preview, so its four CRUD views were
unreachable by any route; and nodes#update redirects on every path.
| -rw-r--r-- | app/controllers/menu_items_controller.rb | 3 | ||||
| -rw-r--r-- | app/views/menu_items/create.html.erb | 2 | ||||
| -rw-r--r-- | app/views/menu_items/delete.html.erb | 2 | ||||
| -rw-r--r-- | app/views/menu_items/show.html.erb | 2 | ||||
| -rw-r--r-- | app/views/menu_items/update.html.erb | 2 | ||||
| -rw-r--r-- | app/views/nodes/update.html.erb | 2 | ||||
| -rw-r--r-- | app/views/pages/edit.html.erb | 24 | ||||
| -rw-r--r-- | app/views/pages/index.html.erb | 24 | ||||
| -rw-r--r-- | app/views/pages/new.html.erb | 31 | ||||
| -rw-r--r-- | app/views/pages/show.html.erb | 28 | ||||
| -rw-r--r-- | config/routes.rb | 2 |
11 files changed, 1 insertions, 121 deletions
diff --git a/app/controllers/menu_items_controller.rb b/app/controllers/menu_items_controller.rb index 8b4e636e..48018800 100644 --- a/app/controllers/menu_items_controller.rb +++ b/app/controllers/menu_items_controller.rb | |||
| @@ -11,9 +11,6 @@ class MenuItemsController < ApplicationController | |||
| 11 | @menu_items = MenuItem.order("position ASC").all | 11 | @menu_items = MenuItem.order("position ASC").all |
| 12 | end | 12 | end |
| 13 | 13 | ||
| 14 | def show | ||
| 15 | end | ||
| 16 | |||
| 17 | def new | 14 | def new |
| 18 | @menu_item = MenuItem.new | 15 | @menu_item = MenuItem.new |
| 19 | end | 16 | end |
diff --git a/app/views/menu_items/create.html.erb b/app/views/menu_items/create.html.erb deleted file mode 100644 index 023f7b9a..00000000 --- a/app/views/menu_items/create.html.erb +++ /dev/null | |||
| @@ -1,2 +0,0 @@ | |||
| 1 | <h1>MenuItems#create</h1> | ||
| 2 | <p>Find me in app/views/menu_items/create.html.erb</p> | ||
diff --git a/app/views/menu_items/delete.html.erb b/app/views/menu_items/delete.html.erb deleted file mode 100644 index 762b16ef..00000000 --- a/app/views/menu_items/delete.html.erb +++ /dev/null | |||
| @@ -1,2 +0,0 @@ | |||
| 1 | <h1>MenuItems#delete</h1> | ||
| 2 | <p>Find me in app/views/menu_items/delete.html.erb</p> | ||
diff --git a/app/views/menu_items/show.html.erb b/app/views/menu_items/show.html.erb deleted file mode 100644 index 65f9ef19..00000000 --- a/app/views/menu_items/show.html.erb +++ /dev/null | |||
| @@ -1,2 +0,0 @@ | |||
| 1 | <h1>MenuItems#show</h1> | ||
| 2 | <p>Find me in app/views/menu_items/show.html.erb</p> | ||
diff --git a/app/views/menu_items/update.html.erb b/app/views/menu_items/update.html.erb deleted file mode 100644 index 3df2a43d..00000000 --- a/app/views/menu_items/update.html.erb +++ /dev/null | |||
| @@ -1,2 +0,0 @@ | |||
| 1 | <h1>MenuItems#update</h1> | ||
| 2 | <p>Find me in app/views/menu_items/update.html.erb</p> | ||
diff --git a/app/views/nodes/update.html.erb b/app/views/nodes/update.html.erb deleted file mode 100644 index 5c6caa8d..00000000 --- a/app/views/nodes/update.html.erb +++ /dev/null | |||
| @@ -1,2 +0,0 @@ | |||
| 1 | <h1>Nodes#update</h1> | ||
| 2 | <p>Find me in app/views/nodes/update.html.erb</p> | ||
diff --git a/app/views/pages/edit.html.erb b/app/views/pages/edit.html.erb deleted file mode 100644 index 8b1242cc..00000000 --- a/app/views/pages/edit.html.erb +++ /dev/null | |||
| @@ -1,24 +0,0 @@ | |||
| 1 | <h1>Editing page</h1> | ||
| 2 | |||
| 3 | <%= form_for(@page) do |f| %> | ||
| 4 | <%= form_error_messages(f) %> | ||
| 5 | |||
| 6 | <p> | ||
| 7 | <%= f.label :title %><br /> | ||
| 8 | <%= f.text_field :title %> | ||
| 9 | </p> | ||
| 10 | <p> | ||
| 11 | <%= f.label :abstract %><br /> | ||
| 12 | <%= f.text_area :abstract %> | ||
| 13 | </p> | ||
| 14 | <p> | ||
| 15 | <%= f.label :body %><br /> | ||
| 16 | <%= f.text_area :body %> | ||
| 17 | </p> | ||
| 18 | <p> | ||
| 19 | <%= f.submit "Update" %> | ||
| 20 | </p> | ||
| 21 | <% end %> | ||
| 22 | |||
| 23 | <%= link_to 'Show', @page %> | | ||
| 24 | <%= link_to 'Back', pages_path %> | ||
diff --git a/app/views/pages/index.html.erb b/app/views/pages/index.html.erb deleted file mode 100644 index da67871c..00000000 --- a/app/views/pages/index.html.erb +++ /dev/null | |||
| @@ -1,24 +0,0 @@ | |||
| 1 | <h1>Pages</h1> | ||
| 2 | |||
| 3 | <table> | ||
| 4 | <tr> | ||
| 5 | <th>Node</th> | ||
| 6 | <th>Title</th> | ||
| 7 | </tr> | ||
| 8 | |||
| 9 | <% for page in @pages %> | ||
| 10 | <tr> | ||
| 11 | <td><%=h page.node_id %></td> | ||
| 12 | <td><%=h page.title %></td> | ||
| 13 | <td><%= link_to 'Show', content_path(:page_path => page.node.unique_path) %></td> | ||
| 14 | <td><%= link_to 'Edit', edit_page_path(page) %></td> | ||
| 15 | <td><%= button_to page, method: :delete, form: { data: { confirm: 'Are you sure?' }, class: 'button_to destructive' } do %> | ||
| 16 | <%= icon("trash", library: "tabler", "aria-hidden": true) %> Destroy | ||
| 17 | <% end %></td> | ||
| 18 | </tr> | ||
| 19 | <% end %> | ||
| 20 | </table> | ||
| 21 | |||
| 22 | <br /> | ||
| 23 | |||
| 24 | <%= link_to 'New page', new_page_path %> | ||
diff --git a/app/views/pages/new.html.erb b/app/views/pages/new.html.erb deleted file mode 100644 index 2758faf5..00000000 --- a/app/views/pages/new.html.erb +++ /dev/null | |||
| @@ -1,31 +0,0 @@ | |||
| 1 | <h1>New page</h1> | ||
| 2 | |||
| 3 | <%= form_for(@page) do |f| %> | ||
| 4 | <%= form_error_messages(f) %> | ||
| 5 | |||
| 6 | <p> | ||
| 7 | <%= f.label :node_id %><br /> | ||
| 8 | <%= f.text_field :node_id %> | ||
| 9 | </p> | ||
| 10 | <p> | ||
| 11 | <%= f.label :title %><br /> | ||
| 12 | <%= f.text_field :title %> | ||
| 13 | </p> | ||
| 14 | <p> | ||
| 15 | <%= f.label :abstract %><br /> | ||
| 16 | <%= f.text_area :abstract %> | ||
| 17 | </p> | ||
| 18 | <p> | ||
| 19 | <%= f.label :body %><br /> | ||
| 20 | <%= f.text_area :body %> | ||
| 21 | </p> | ||
| 22 | <p> | ||
| 23 | <%= f.label :revision %><br /> | ||
| 24 | <%= f.text_field :revision %> | ||
| 25 | </p> | ||
| 26 | <p> | ||
| 27 | <%= f.submit "Create" %> | ||
| 28 | </p> | ||
| 29 | <% end %> | ||
| 30 | |||
| 31 | <%= link_to 'Back', pages_path %> | ||
diff --git a/app/views/pages/show.html.erb b/app/views/pages/show.html.erb deleted file mode 100644 index 254b9406..00000000 --- a/app/views/pages/show.html.erb +++ /dev/null | |||
| @@ -1,28 +0,0 @@ | |||
| 1 | <p> | ||
| 2 | <b>Node:</b> | ||
| 3 | <%=h @page.node_id %> | ||
| 4 | </p> | ||
| 5 | |||
| 6 | <p> | ||
| 7 | <b>Title:</b> | ||
| 8 | <%=h @page.title %> | ||
| 9 | </p> | ||
| 10 | |||
| 11 | <p> | ||
| 12 | <b>Abstract:</b> | ||
| 13 | <%=h @page.abstract %> | ||
| 14 | </p> | ||
| 15 | |||
| 16 | <p> | ||
| 17 | <b>Body:</b> | ||
| 18 | <%=h @page.body %> | ||
| 19 | </p> | ||
| 20 | |||
| 21 | <p> | ||
| 22 | <b>Revision:</b> | ||
| 23 | <%=h @page.revision %> | ||
| 24 | </p> | ||
| 25 | |||
| 26 | |||
| 27 | <%= link_to 'Edit', edit_page_path(@page) %> | | ||
| 28 | <%= link_to 'Back', pages_path %> | ||
diff --git a/config/routes.rb b/config/routes.rb index 862647df..9793c6a6 100644 --- a/config/routes.rb +++ b/config/routes.rb | |||
| @@ -105,7 +105,7 @@ Cccms::Application.routes.draw do | |||
| 105 | resource :otp_enrollment, :only => [:show, :create, :update, :destroy] | 105 | resource :otp_enrollment, :only => [:show, :create, :update, :destroy] |
| 106 | resource :otp_challenge, :only => [:new, :create] | 106 | resource :otp_challenge, :only => [:new, :create] |
| 107 | 107 | ||
| 108 | resources :menu_items do | 108 | resources :menu_items, :except => :show do |
| 109 | member do | 109 | member do |
| 110 | post :sort | 110 | post :sort |
| 111 | end | 111 | end |
