diff options
| author | erdgeist <erdgeist@erdgeist.org> | 2026-08-13 01:11:29 +0200 |
|---|---|---|
| committer | erdgeist <erdgeist@erdgeist.org> | 2026-08-13 01:11:29 +0200 |
| commit | 862edbf4d5fdb9a88f84bfa1d51ab8cc83896094 (patch) | |
| tree | 2b8d8082b3549f664ef6f4babff3be864af4aac8 /app/views/menu_items | |
| parent | a06f35bc0085aa744aef5fe2f4c4c036338b469b (diff) | |
Give every admin page one horizontal gutter
by many views inside. The inner ones are gone
nodes#edit's becomes #body_field, which is what #edit_grid places in its
full-width row.
Rows now reach into the label band themselves rather than depending on a
page wrapper to do it. The label column plus its gap equals the escape, so
a row's content starts at the gutter on every page; #edit_grid's rows are
exempt because the grid already steps back.
share one left edge. #new_node's -118px was compensating for that 10px and
left the page 7px out once it went. standalone_action_bar was overridden
everywhere it appeared.
page_translations#edit no longer uses #edit_grid: it has no metadata column,
so the two-column template pushed its abstract into the empty half.
nodes#edit's lower action bar was inside #edit_grid, so it was a grid item
inheriting the escape and sat 125px left of the form above it.
Diffstat (limited to 'app/views/menu_items')
| -rw-r--r-- | app/views/menu_items/_title_fields.html.erb | 16 | ||||
| -rw-r--r-- | app/views/menu_items/edit.html.erb | 30 | ||||
| -rw-r--r-- | app/views/menu_items/new.html.erb | 27 |
3 files changed, 45 insertions, 28 deletions
diff --git a/app/views/menu_items/_title_fields.html.erb b/app/views/menu_items/_title_fields.html.erb index 81ec4ad6..daf449cf 100644 --- a/app/views/menu_items/_title_fields.html.erb +++ b/app/views/menu_items/_title_fields.html.erb | |||
| @@ -1,10 +1,12 @@ | |||
| 1 | <% (I18n.available_locales - [:root]).each do |locale| %> | 1 | <% (I18n.available_locales - [:root]).each do |locale| %> |
| 2 | <div class="layout_row_label"> | 2 | <div class="layout_row"> |
| 3 | <%= MenuItem.human_attribute_name(:title) %> <%= locale.to_s.upcase %> | 3 | <div class="layout_row_label"> |
| 4 | </div> | 4 | <%= MenuItem.human_attribute_name(:title) %> <%= locale.to_s.upcase %> |
| 5 | <div class="layout_row_content"> | 5 | </div> |
| 6 | <%= text_field_tag "menu_item[titles][#{locale}]", | 6 | <div class="layout_row_content"> |
| 7 | menu_item.translations.find_by(:locale => locale)&.title, | 7 | <%= text_field_tag "menu_item[titles][#{locale}]", |
| 8 | :placeholder => (locale == I18n.default_locale ? nil : t(".falls_back")) %> | 8 | menu_item.translations.find_by(:locale => locale)&.title, |
| 9 | :placeholder => (locale == I18n.default_locale ? nil : t(".falls_back")) %> | ||
| 10 | </div> | ||
| 9 | </div> | 11 | </div> |
| 10 | <% end %> | 12 | <% end %> |
diff --git a/app/views/menu_items/edit.html.erb b/app/views/menu_items/edit.html.erb index 2bd65575..92e358d6 100644 --- a/app/views/menu_items/edit.html.erb +++ b/app/views/menu_items/edit.html.erb | |||
| @@ -2,23 +2,29 @@ | |||
| 2 | 2 | ||
| 3 | <div id="admin_layout"> | 3 | <div id="admin_layout"> |
| 4 | <%= form_for @menu_item do |f| %> | 4 | <%= form_for @menu_item do |f| %> |
| 5 | <div id="content"> | 5 | <div class="layout_row"> |
| 6 | <div class="layout_row_label"><%= t("admin.common.search") %></div> | 6 | <div class="layout_row_label"><%= t("admin.common.search") %></div> |
| 7 | <div class="layout_row_content"> | 7 | <div class="layout_row_content"> |
| 8 | <%= text_field_tag :menu_search_term %> | 8 | <%= text_field_tag :menu_search_term %> |
| 9 | <div id="menu_item_search_results" class="search_results"></div> | 9 | <div id="menu_item_search_results" class="search_results"></div> |
| 10 | </div> | ||
| 10 | </div> | 11 | </div> |
| 11 | 12 | ||
| 12 | <div class="layout_row_label"><%= MenuItem.human_attribute_name(:node_id) %></div> | 13 | <div class="layout_row"> |
| 13 | <div class="layout_row_content"><%= f.text_field :node_id %></div> | 14 | <div class="layout_row_label"><%= MenuItem.human_attribute_name(:node_id) %></div> |
| 15 | <div class="layout_row_content"><%= f.text_field :node_id %></div> | ||
| 16 | </div> | ||
| 14 | 17 | ||
| 15 | <div class="layout_row_label"><%= MenuItem.human_attribute_name(:path) %></div> | 18 | <div class="layout_row"> |
| 16 | <div class="layout_row_content"><%= f.text_field :path %></div> | 19 | <div class="layout_row_label"><%= MenuItem.human_attribute_name(:path) %></div> |
| 20 | <div class="layout_row_content"><%= f.text_field :path %></div> | ||
| 21 | </div> | ||
| 17 | 22 | ||
| 18 | <%= render "title_fields", :menu_item => @menu_item %> | 23 | <%= render "title_fields", :menu_item => @menu_item %> |
| 19 | 24 | ||
| 20 | <div class="layout_row_label"></div> | 25 | <div class="layout_row"> |
| 21 | <div class="layout_row_content"><%= f.submit t("admin.common.update") %></div> | 26 | <div class="layout_row_label"></div> |
| 27 | <div class="layout_row_content"><%= f.submit t("admin.common.update") %></div> | ||
| 28 | </div> | ||
| 22 | <% end %> | 29 | <% end %> |
| 23 | </div> | ||
| 24 | </div> | 30 | </div> |
diff --git a/app/views/menu_items/new.html.erb b/app/views/menu_items/new.html.erb index 08872ec0..047a5a25 100644 --- a/app/views/menu_items/new.html.erb +++ b/app/views/menu_items/new.html.erb | |||
| @@ -1,19 +1,28 @@ | |||
| 1 | <h1><%= t(".title") %></h1> | 1 | <h1><%= t(".title") %></h1> |
| 2 | 2 | ||
| 3 | <%= form_for @menu_item do |f| %> | 3 | <%= form_for @menu_item do |f| %> |
| 4 | <div class="layout_row_label"><%= t("admin.common.search") %></div> | 4 | <div class="layout_row"> |
| 5 | <div class="layout_row_content"> | 5 | <div class="layout_row_label"><%= t("admin.common.search") %></div> |
| 6 | <%= text_field_tag :menu_search_term %> | 6 | <div class="layout_row_content"> |
| 7 | <div id="menu_item_search_results" class="search_results"></div> | 7 | <%= text_field_tag :menu_search_term %> |
| 8 | <div id="menu_item_search_results" class="search_results"></div> | ||
| 9 | </div> | ||
| 8 | </div> | 10 | </div> |
| 9 | 11 | ||
| 10 | <div class="layout_row_label"><%= MenuItem.human_attribute_name(:node_id) %></div> | 12 | <div class="layout_row"> |
| 11 | <div class="layout_row_content"><%= f.text_field :node_id %></div> | 13 | <div class="layout_row_label"><%= MenuItem.human_attribute_name(:node_id) %></div> |
| 14 | <div class="layout_row_content"><%= f.text_field :node_id %></div> | ||
| 15 | </div> | ||
| 12 | 16 | ||
| 13 | <div class="layout_row_label"><%= MenuItem.human_attribute_name(:path) %></div> | 17 | <div class="layout_row"> |
| 14 | <div class="layout_row_content"><%= f.text_field :path %></div> | 18 | <div class="layout_row_label"><%= MenuItem.human_attribute_name(:path) %></div> |
| 19 | <div class="layout_row_content"><%= f.text_field :path %></div> | ||
| 20 | </div> | ||
| 15 | 21 | ||
| 16 | <%= render "title_fields", :menu_item => @menu_item %> | 22 | <%= render "title_fields", :menu_item => @menu_item %> |
| 17 | 23 | ||
| 18 | <div class="layout_row_content"><%= f.submit t("admin.common.create") %></div> | 24 | <div class="layout_row"> |
| 25 | <div class="layout_row_label"></div> | ||
| 26 | <div class="layout_row_content"><%= f.submit t("admin.common.create") %></div> | ||
| 27 | </div> | ||
| 19 | <% end %> | 28 | <% end %> |
