Re-structure sitemap, all subpages collapsed by default, visually tightened

2 files changed, 17 insertions, 11 deletions

diff --git a/app/helpers/nodes_helper.rb b/app/helpers/nodes_helper.rb
index 48f44f8b..fa3cc443 100644
--- a/app/helpers/nodes_helper.rb
+++ b/app/helpers/nodes_helper.rb
@@ -70,8 +70,4 @@ module NodesHelper
     path = node.unique_path
     CccConventions::NODE_KINDS.select { |_, config| config[:parent_match]&.call(path) }
   end
-
-  def sitemap_node_open?(node)
-    !CccConventions::SITEMAP_COLLAPSED_PATHS.include?(node.unique_name)
-  end
 end
diff --git a/app/views/nodes/sitemap.html.erb b/app/views/nodes/sitemap.html.erb
index 49a59d4c..3b9328da 100644
--- a/app/views/nodes/sitemap.html.erb
+++ b/app/views/nodes/sitemap.html.erb
@@ -15,8 +15,8 @@
 
 <% @sitemap.each_with_index do |(node, level), index| %>
   <% while open_details.any? && open_details.last >= level %>
-    </details>
-    <% open_details.pop %>
+    <% closing = open_details.pop %>
+    <% if closing.zero? %></div><% else %></details><% end %>
   <% end %>
 
   <% unless level.zero? %>
@@ -52,12 +52,22 @@
 
   <% next_level = @sitemap[index + 1]&.last %>
   <% if next_level && next_level > level %>
-    <details<%= ' open' if sitemap_node_open?(node) %>>
-      <summary>
-        <%= t(".descendants", :count => @sitemap_descendant_counts[node.id]) %>
-      </summary>
+    <% if level.zero? %>
+      <%# Root's children are the top level: a tree does not hide its own
+          first rank behind a toggle. A plain div keeps the closing-tag
+          bookkeeping symmetric with the details branches. %>
+      <div class="sitemap_children">
+    <% else %>
+      <details>
+        <summary>
+          <%= t(".descendants", :count => @sitemap_descendant_counts[node.id]) %>
+        </summary>
+    <% end %>
     <% open_details.push(level) %>
   <% end %>
 <% end %>
-<% open_details.length.times { %></details><% } %>
+<% while open_details.any? %>
+  <% closing = open_details.pop %>
+  <% if closing.zero? %></div><% else %></details><% end %>
+<% end %>
 </div>