diff options
| author | erdgeist <erdgeist@erdgeist.org> | 2026-07-20 19:45:43 +0200 |
|---|---|---|
| committer | erdgeist <erdgeist@erdgeist.org> | 2026-07-20 19:45:43 +0200 |
| commit | 836308471f8d31ccdcdd3a5bd88bc76cc1c0831b (patch) | |
| tree | 821a526d4d10870654a38d07a4eb53a2180ba313 /test/models/asset_test.rb | |
| parent | d89e2de48a5e16ff01ec627e79c76b833e4618cf (diff) | |
Make headline images explicit, add asset credits
- related_assets gains a `headline` boolean (DB-enforced: at most one
per page), replacing "first image by position" as the headline
rule. A rake task backfills the current first image on every live
head/draft, so nothing changes visually until an editor changes it.
- The image picker sidebar gets a star toggle reflecting the flag;
the TinyMCE inline-image picker's badge now reads it too, instead
of assuming position 0.
- No headline chosen (or none attached) now falls back to the
gallery-count caption itself becoming the lightbox trigger, instead
of the gallery being unreachable.
- Assets gain creator, source_url, and license_key (against a new
config/asset_licenses.yml dictionary). asset_credit renders a
degrading attribution line, reused as a hidden per-image glightbox
caption so credit is one click away for every image, not only the
headline's always-visible one.
- Fixed: asset thumbnails rendered unconditionally regardless of
whether a real variant exists on disk. Asset#has_variant? checks
file existence, not content type -- some legacy PDFs have real
pre-rewrite thumbnails a content-type check would have hidden.
- assets#new/edit rebuilt onto the same node_description/node_content
layout as assets#show, picking up the three new fields in the
process.
Diffstat (limited to 'test/models/asset_test.rb')
| -rw-r--r-- | test/models/asset_test.rb | 23 |
1 files changed, 22 insertions, 1 deletions
diff --git a/test/models/asset_test.rb b/test/models/asset_test.rb index a1041e45..d246abe0 100644 --- a/test/models/asset_test.rb +++ b/test/models/asset_test.rb | |||
| @@ -19,5 +19,26 @@ class AssetTest < ActiveSupport::TestCase | |||
| 19 | assert_equal 0, draft.assets.length | 19 | assert_equal 0, draft.assets.length |
| 20 | assert_equal 0, RelatedAsset.count | 20 | assert_equal 0, RelatedAsset.count |
| 21 | end | 21 | end |
| 22 | 22 | ||
| 23 | test "image? is true for supported image content types" do | ||
| 24 | assert Asset.new(:upload_content_type => "image/png").image? | ||
| 25 | assert Asset.new(:upload_content_type => "image/jpeg").image? | ||
| 26 | end | ||
| 27 | |||
| 28 | test "image? is false for non-image content types" do | ||
| 29 | assert_not Asset.new(:upload_content_type => "application/pdf").image? | ||
| 30 | assert_not Asset.new(:upload_content_type => nil).image? | ||
| 31 | end | ||
| 32 | |||
| 33 | test "license_key must be a known dictionary key" do | ||
| 34 | asset = Asset.new(:license_key => "not_a_real_license") | ||
| 35 | I18n.with_locale(:en) do | ||
| 36 | assert_not asset.valid? | ||
| 37 | assert_includes asset.errors[:license_key], "is not included in the list" | ||
| 38 | end | ||
| 39 | end | ||
| 40 | |||
| 41 | test "license_key may be blank" do | ||
| 42 | assert Asset.new(:license_key => nil).valid? | ||
| 43 | end | ||
| 23 | end | 44 | end |
