Witness asset uploads and out-of-band attaches in the action log

2 files changed, 29 insertions, 0 deletions

diff --git a/test/controllers/assets_controller_test.rb b/test/controllers/assets_controller_test.rb
index 0e251aad..4be2e8a1 100644
--- a/test/controllers/assets_controller_test.rb
+++ b/test/controllers/assets_controller_test.rb
@@ -133,6 +133,16 @@ class AssetsControllerTest < ActionController::TestCase
     assert_equal node_path(node), flash[:headline_kept_path]
   end
 
+  test "create with node_id writes an asset_create and an asset_attach entry" do
+    node = Node.root.children.create!(:slug => "asset_log_pair")
+    assert_difference 'NodeAction.where(:action => "asset_create").count' do
+      assert_difference 'NodeAction.where(:action => "asset_attach").count' do
+        post :create, params: { asset: { name: 'Logged twice' }, node_id: node.id }
+      end
+    end
+    assert_equal users(:quentin), NodeAction.last.user
+  end
+
   # --- edit ---
 
   test "get edit" do
diff --git a/test/models/node_attach_asset_test.rb b/test/models/node_attach_asset_test.rb
index cb5b60f5..2df2cfbb 100644
--- a/test/models/node_attach_asset_test.rb
+++ b/test/models/node_attach_asset_test.rb
@@ -95,6 +95,25 @@ class NodeAttachAssetTest < ActiveSupport::TestCase
     assert_raises(ActiveRecord::RecordInvalid) { @node.attach_asset!(@image, :user => @user) }
   end
 
+  test "attaching writes an asset_attach entry with node and asset participants" do
+    result = @node.attach_asset!(@image, :user => @user, :headline => true)
+    assert_equal :set, result[:headline]
+
+    action = NodeAction.where(:action => "asset_attach").last
+    assert_equal @node, action.node
+    subjects = action.action_participants.map { |p| [p.subject_type, p.subject_id] }
+    assert_includes subjects, ["Node", @node.id]
+    assert_includes subjects, ["Asset", @image.id]
+    assert action.metadata["headline"]
+  end
+
+  test "a fully redundant attach writes no entry" do
+    @node.attach_asset!(@image, :user => @user)
+    assert_no_difference 'NodeAction.count' do
+      @node.attach_asset!(@image, :user => @user)
+    end
+  end
+
   private
 
     def create_image_asset