Split nodes#edit into a four-quadrant layout on desktop

3 files changed, 112 insertions, 72 deletions

diff --git a/app/views/nodes/edit.html.erb b/app/views/nodes/edit.html.erb
index 12dc000..fc1d18f 100644
--- a/app/views/nodes/edit.html.erb
+++ b/app/views/nodes/edit.html.erb
@@ -33,48 +33,17 @@
     </div>
   <% end %>
 
-  <details id="metadata_details">
-    <summary>Metadata (slug, parent, tags, template, author, images)</summary>
-    <div id="metadata">
-      <div class="node_description">Slug</div>
-      <div class="node_content">
-        <%= f.text_field(
-              :staged_slug, :value => @node.staged_slug || @node.slug
-            )
-          %>
-      </div>
+  <%= fields_for @page do |d| %>
+  <div id="edit_grid">
 
-      <div class="node_description">parent</div>
-      <div class="node_content">
-        <%= text_field_tag :move_to_search_term, @node.parent.title rescue "" %>
-        <div id="move_to_search_results" class="search_results"></div>
-        <%= f.hidden_field(
-              :staged_parent_id,
-              :value => @node.staged_parent_id || @node.parent_id
-            )
-         %>
-      </div>
+    <div id="main_fields">
+      <div class="node_description">Title</div>
+      <div class="node_content"><%= d.text_field :title %></div>
 
-      <%= fields_for @page do |d| %>
-      <div class="node_description">Tags - comma seperated</div>
-      <div class="node_content"><%= text_field_tag :tag_list, @page.tag_list.join(', ') %></div>
+      <div class="node_description">Abstract</div>
+      <div class="node_content"><%= d.text_area :abstract %></div>
 
-      <div class="node_description">Publish at</div>
-      <div class="node_content"><%= d.datetime_select :published_at, :value => @page.published_at %></div>
-
-      <div class="node_description">Template</div>
-      <div class="node_content">
-      <%= d.select :template_name, custom_page_templates, {:prompt => 'Select Template'} %>
-      <span class="field_hint">Set automatically based on how this node was created - change it if needed.</span>
-      </div>
-
-      <div class="node_description">Author</div>
-      <div class="node_content">
-        <%= d.select :user_id, user_list,
-              :selected => @page.user_id || @node.draft&.user_id || @node.head&.user_id %>
-      </div>
-
-      <div class="node_description">Images</div>
+      <div class="node_description">Attachments</div>
       <div class="node_content">
         <div id="related_assets"
              data-search-url="<%= search_node_related_assets_path(@node) %>"
@@ -120,33 +89,73 @@
           </button>
         </li>
       </template>
-
     </div>
-  </details>
 
-  <div id="content">
-    <div class="node_description">Title</div>
-    <div class="node_content"><%= d.text_field :title %></div>
+    <details id="metadata_details">
+      <summary>Metadata (slug, parent, tags, template, author, images)</summary>
+      <div id="metadata">
+        <div class="node_description">Slug</div>
+        <div class="node_content">
+          <%= f.text_field(
+                :staged_slug, :value => @node.staged_slug || @node.slug
+              )
+            %>
+        </div>
+
+        <div class="node_description">parent</div>
+        <div class="node_content">
+          <%= text_field_tag :move_to_search_term, @node.parent.title rescue "" %>
+          <p class="field_hint">Start typing to find a new parent for this node.</p>
+          <div id="move_to_search_results" class="search_results"></div>
+          <%= f.hidden_field(
+                :staged_parent_id,
+                :value => @node.staged_parent_id || @node.parent_id
+              )
+           %>
+        </div>
 
-    <div class="node_description">Abstract</div>
-    <div class="node_content"><%= d.text_area :abstract %></div>
+        <div class="node_description">Tags</div>
+        <div class="node_content">
+          <%= text_field_tag :tag_list, @page.tag_list.join(', ') %>
+          <span class="field_hint">Comma separated.</span>
+        </div>
 
-    <div class="node_description">Body</div>
-    <div class="body_toolbar_row">
-      <button type="button" id="preview_toggle" class="view_toggle" aria-pressed="false" aria-label="Toggle live preview" title="Toggle live preview">
-        <%= icon("layout-sidebar-right", library: "tabler", "aria-hidden": true) %> <span>Live preview</span>
-      </button>
-      <button type="button" id="preview_force_render" class="view_toggle" style="display:none" aria-label="Force preview render" title="Force preview render">
-        <%= icon("refresh", library: "tabler", "aria-hidden": true) %> <span>Force refresh</span>
-      </button>
-    </div>
+        <div class="node_description">Publish at</div>
+        <div class="node_content"><%= d.datetime_select :published_at, :value => @page.published_at %></div>
 
-    <div id="editor_and_preview">
-      <div class="preview_content">
-        <div class="node_content"><%= d.text_area :body, :class => 'with_editor' %></div>
+        <div class="node_description">Template</div>
+        <div class="node_content">
+        <%= d.select :template_name, custom_page_templates, {:prompt => 'Select Template'} %>
+        <span class="field_hint">Set automatically based on how this node was created - change it if needed.</span>
+        </div>
+
+        <div class="node_description">Author</div>
+        <div class="node_content">
+          <%= d.select :user_id, user_list,
+                :selected => @page.user_id || @node.draft&.user_id || @node.head&.user_id %>
+        </div>
+
+      </div>
+    </details>
+
+    <div id="content">
+      <div class="node_description">Body</div>
+      <div class="body_toolbar_row">
+        <button type="button" id="preview_toggle" class="view_toggle" aria-pressed="false" aria-label="Toggle live preview" title="Toggle live preview">
+          <%= icon("layout-sidebar-right", library: "tabler", "aria-hidden": true) %> <span>Live preview</span>
+        </button>
+        <button type="button" id="preview_force_render" class="view_toggle" style="display:none" aria-label="Force preview render" title="Force preview render">
+          <%= icon("refresh", library: "tabler", "aria-hidden": true) %> <span>Force refresh</span>
+        </button>
       </div>
-      <div id="preview_panel" style="display:none">
-        <iframe id="live_preview_iframe" title="Live preview" data-src="<%= preview_page_path(@page, :locale => I18n.default_locale) %>"></iframe>
+
+      <div id="editor_and_preview">
+        <div class="preview_content">
+          <div class="node_content"><%= d.text_area :body, :class => 'with_editor' %></div>
+        </div>
+        <div id="preview_panel" style="display:none">
+          <iframe id="live_preview_iframe" title="Live preview" data-src="<%= preview_page_path(@page, :locale => I18n.default_locale) %>"></iframe>
+        </div>
       </div>
     </div>
   </div>
diff --git a/public/javascripts/admin_interface.js b/public/javascripts/admin_interface.js
index f6d915f..64da5a8 100644
--- a/public/javascripts/admin_interface.js
+++ b/public/javascripts/admin_interface.js
@@ -73,6 +73,14 @@ $(document).ready(function () {
     cccms.preview.initialize();
   }
 
+  var metadata_details = document.getElementById('metadata_details');
+  if (metadata_details) {
+    var desktop_mq = window.matchMedia('(min-width: 1016px)');
+    var sync_metadata = function() { metadata_details.open = desktop_mq.matches; };
+    sync_metadata();
+    desktop_mq.addEventListener('change', sync_metadata);
+  }
+
   jQuery.ajaxSetup({
     'beforeSend': function(xhr) {xhr.setRequestHeader("Accept", "text/javascript");}
   });
diff --git a/public/stylesheets/admin.css b/public/stylesheets/admin.css
index 7b06c7d..5c0a8c0 100644
--- a/public/stylesheets/admin.css
+++ b/public/stylesheets/admin.css
@@ -97,7 +97,8 @@ input[type=radio] {
 }
 
 #metadata,
-#content {
+#content,
+#main_fields {
   margin-left: 5px;
 }
 
@@ -892,6 +893,26 @@ form.button_to button[type="submit"] {
    Page editor / metadata forms
    ============================================================ */
 
+@media(min-width:1016px) {
+  #edit_grid {
+    display: grid;
+    grid-template-columns: 1fr 1fr;
+    grid-template-areas:
+      "main meta"
+      "body body";
+    column-gap: 2rem;
+    align-items: start;
+    margin-left: -125px;
+  }
+  #main_fields       { grid-area: main; }
+  #metadata_details  { grid-area: meta; }
+  #page_editor #content { grid-area: body; }
+
+  /* Details is force-opened by JS on desktop; hide the summary only
+     once open, so a JS failure still leaves a working toggle. */
+  #metadata_details[open] > summary { display: none; }
+}
+
 #new_node {
   margin-left: -118px;
 }
@@ -947,18 +968,16 @@ div#page_editor {
 }
 
 @media(min-width:1016px) {
-  input#tag_list,
   input#menu_search_term,
   input#menu_item_node_id,
   input#menu_item_path,
-  input#menu_item_title,
-  input#node_staged_slug,
-  input#move_to_search_term {
+  input#menu_item_title {
     width: 690px;
   }
 
   input[type=text]#page_title {
-    width: 690px;
+    width: 100%;
+    box-sizing: border-box;
     font-size: 1rem;
     padding-top: 6px;
     padding-bottom: 4px;
@@ -968,24 +987,27 @@ div#page_editor {
   }
 
   textarea#page_abstract {
-    width: 690px;
-    height: 150px;
+    width: 100%;
+    box-sizing: border-box;
+    height: 250px;
     padding: 5px;
   }
 
   #page_editor textarea#page_body {
-    width: 700px;
+    width: 100%;
+    box-sizing: border-box;
     height: 600px;
   }
 
-  #page_editor #metadata, #page_editor #content, #admin_overview {
+  #admin_overview {
     margin-left: -125px;
   }
 
   #page_editor input[type=text],
   #page_editor input[type=password],
   #page_editor textarea {
-    width: 690px;
+    width: 100%;
+    box-sizing: border-box;
   }
 }
 
@@ -998,7 +1020,8 @@ div#page_editor {
   }
 
   #page_editor #content,
-  #page_editor #metadata {
+  #page_editor #metadata,
+  #page_editor #main_fields {
     padding-right: 5px;
   }