Wire real autosave into translation editing

The shared TinyMCE setup initializes cccms.setup_autosave() on any
page with a textarea.with_editor, unconditionally starting a
7-second interval that submits to the form's data-autosave-url --
which the translation edit form never set, so the interval PUT the
current page URL itself and 404'd on a nonexistent route.

Fixed by actually giving it something to talk to, rather than
suppressing it: a real autosave endpoint, and update now goes
through Node#autosave!/#save_draft! -- the same pipeline the
primary editor uses, fixed earlier this session for exactly this
kind of cross-locale carryover. This was the autosave-buffer parity
already flagged as due after the proof of concept; the shared JS
just forced the timing.

4 files changed, 40 insertions, 6 deletions

diff --git a/app/controllers/page_translations_controller.rb b/app/controllers/page_translations_controller.rb
index 47f01f7..9446cd2 100644
--- a/app/controllers/page_translations_controller.rb
+++ b/app/controllers/page_translations_controller.rb
@@ -3,7 +3,7 @@ class PageTranslationsController < ApplicationController
 
   before_action :login_required
   before_action :find_node
-  before_action :find_locale, :only => [:show, :edit, :update, :destroy]
+  before_action :find_locale, :only => [:show, :edit, :update, :autosave, :destroy]
 
   def index
     page = @node.draft || @node.head
@@ -26,8 +26,8 @@ class PageTranslationsController < ApplicationController
   end
 
   def update
-    draft = ensure_editable_draft
-    Globalize.with_locale(@locale) { draft.update!(translation_params) }
+    Globalize.with_locale(@locale) { @node.autosave!(translation_params, current_user) }
+    @node.save_draft!(current_user)
     flash[:notice] = "#{@locale.upcase} translation saved. Publish the draft to make it live."
 
     if params[:commit] == "Save + Unlock + Exit"
@@ -41,6 +41,17 @@ class PageTranslationsController < ApplicationController
     redirect_to node_path(@node)
   end
 
+  def autosave
+    Globalize.with_locale(@locale) { @node.autosave!(translation_params, current_user) }
+    head :ok
+  rescue LockedByAnotherUser => e
+    render plain: e.message, status: :locked
+  rescue ActiveRecord::RecordInvalid => e
+    render plain: e.message, status: :unprocessable_entity
+  rescue StandardError => e
+    render plain: "Autosave failed", status: :internal_server_error
+  end
+
   def destroy
     base = @node.draft || @node.head
     unless base && base.translated_locales.include?(@locale)
diff --git a/app/views/page_translations/edit.html.erb b/app/views/page_translations/edit.html.erb
index 7371a42..89b594e 100644
--- a/app/views/page_translations/edit.html.erb
+++ b/app/views/page_translations/edit.html.erb
@@ -18,7 +18,8 @@
 </div>
 
 <div id="page_editor">
-  <%= form_with url: node_translation_path(@node, @locale), method: :patch, local: true, id: "translation_edit_form" do |f| %>
+    <%= form_with url: node_translation_path(@node, @locale), method: :patch, local: true, id: "translation_edit_form",
+          data: { autosave_url: autosave_node_translation_path(@node, @locale), show_url: node_path(@node) } do |f| %>
     <div id="content">
       <div class="node_description">Title</div>
       <div class="node_content">
diff --git a/config/routes.rb b/config/routes.rb
index 38a497d..826bb18 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -58,8 +58,11 @@ Cccms::Application.routes.draw do
         resources :translations, controller: 'page_translations',
           param: :translation_locale,
           constraints: { translation_locale: /en/ },
-          only: [:index, :show, :edit, :update, :destroy]
-
+          only: [:index, :show, :edit, :update, :destroy] do
+          member do
+            put :autosave
+          end
+        end
 
         resources :related_assets, only: [:create, :destroy, :update] do
           collection do
diff --git a/test/controllers/page_translations_controller_test.rb b/test/controllers/page_translations_controller_test.rb
index d84ac45..8c899fd 100644
--- a/test/controllers/page_translations_controller_test.rb
+++ b/test/controllers/page_translations_controller_test.rb
@@ -18,6 +18,7 @@ class PageTranslationsControllerTest < ActionController::TestCase
     node = Node.root.children.create!(:slug => "translations_create_test")
     Globalize.with_locale(:de) { node.draft.update!(:title => "Deutscher Titel") }
     node.publish_draft!
+    node.lock_for_editing!(users(:quentin))
 
     patch :update, params: { :node_id => node.id, :translation_locale => "en", :page => { :title => "English Title" } }
 
@@ -39,6 +40,7 @@ class PageTranslationsControllerTest < ActionController::TestCase
   test "update with Save + Unlock + Exit unlocks the node and redirects to nodes#show" do
     login_as :quentin
     node = Node.root.children.create!(:slug => "translations_exit_test")
+    node.lock_for_editing!(users(:quentin))
 
     patch :update, params: { :node_id => node.id, :translation_locale => "en", :page => { :title => "x" }, :commit => "Save + Unlock + Exit" }
 
@@ -50,6 +52,7 @@ class PageTranslationsControllerTest < ActionController::TestCase
     login_as :quentin
     node = Node.root.children.create!(:slug => "translations_update_test")
     Globalize.with_locale(:en) { node.draft.update!(:title => "Original") }
+    node.lock_for_editing!(users(:quentin))
 
     patch :update, params: { :node_id => node.id, :translation_locale => "en", :page => { :title => "Revised" } }
 
@@ -75,4 +78,20 @@ class PageTranslationsControllerTest < ActionController::TestCase
 
     assert_match(/No EN translation exists/, flash[:error])
   end
+
+  test "autosave writes the translation without creating a new revision or touching the draft" do
+    login_as :quentin
+    node = Node.root.children.create!(:slug => "translations_autosave_test")
+    node.publish_draft!
+    node.lock_for_editing!(users(:quentin))
+    page_count_before = node.pages.count
+
+    put :autosave, params: { :node_id => node.id, :translation_locale => "en", :page => { :title => "in progress" } }
+
+    assert_response :success
+    node.reload
+    assert_not_nil node.autosave
+    assert_equal page_count_before, node.pages.count
+    assert_equal "in progress", Globalize.with_locale(:en) { node.autosave.title }
+  end
 end