Fix tagged content aggregator, assets path, and add regression tests

- Replace tagged_with calls in Page.aggregate, TagsController, RssController
  with direct SQL joins (acts-as-taggable-on 3.5 broken on Rails 3.2)
- Fix Paperclip :path/:url to use plain :id format matching existing uploads
- Add proper regression tests for aggregator, tags, and rss controllers
- Fix assert_select assertions to target div.body div.article_partial

2 files changed, 20 insertions, 9 deletions

diff --git a/app/controllers/rss_controller.rb b/app/controllers/rss_controller.rb
index 70a642c..be9cd2c 100644
--- a/app/controllers/rss_controller.rb
+++ b/app/controllers/rss_controller.rb
@@ -7,10 +7,15 @@ class RssController < ApplicationController
     expires_in 31.minutes, :public => true
     
     I18n.locale = :de
-   
-    @items = Page.heads.tagged_with("update")
+  
+    @items = Page.heads
+      .joins("JOIN taggings ON taggings.taggable_id = pages.id
+            AND taggings.taggable_type = 'Page'
+            AND taggings.context = 'tags'")
+      .joins("JOIN tags ON tags.id = taggings.tag_id")
+      .where("LOWER(tags.name) = ?", "update")
       .order("published_at DESC").limit(20)
-    
+
     respond_to do |format|
       format.xml {}
       format.rdf {}
diff --git a/app/controllers/tags_controller.rb b/app/controllers/tags_controller.rb
index f09d560..e4ceec9 100644
--- a/app/controllers/tags_controller.rb
+++ b/app/controllers/tags_controller.rb
@@ -12,17 +12,23 @@ class TagsController < ApplicationController
     tag_name = params[:id]
 
     if tag_name.match(/^[a-zA-Z0-9_\w\s\-\.\']+$/)
-      @tag  = Tag.find_by_name(tag_name)
+      @tag = ActsAsTaggableOn::Tag.find_by_name(tag_name)
       @tag  = @tag ? @tag.name : tag_name
       @page = Page.new
 
       params[:page] = (params[:page].is_a?(Integer) ? params[:page] : 1)
 
-      @pages = Page.heads.tagged_with(@tag).paginate(
-        :order    => 'published_at DESC',
-        :page     => params[:page],
-        :per_page => 23
-      )
+      @pages = Page.heads
+        .joins("JOIN taggings ON taggings.taggable_id = pages.id
+            AND taggings.taggable_type = 'Page'
+            AND taggings.context = 'tags'")
+        .joins("JOIN tags ON tags.id = taggings.tag_id")
+        .where("LOWER(tags.name) = ?", @tag.downcase)
+        .order('published_at DESC')
+        .paginate(
+          :page     => params[:page],
+          :per_page => 23
+        )
 
       respond_to do |format|
         format.html {}