summaryrefslogtreecommitdiff
path: root/app/helpers
diff options
context:
space:
mode:
authorerdgeist <erdgeist@erdgeist.org>2026-06-26 13:40:55 +0200
committererdgeist <erdgeist@erdgeist.org>2026-06-26 13:40:55 +0200
commit811bb04649365b0faaa00b1e0810bb101a4d19b1 (patch)
tree581d52faa6e1bf21a1cdfd4da7127a0f95786bad /app/helpers
parenta1ddc25da0d2aa79a4d9216ef7792f26233bd38e (diff)
Stage 5 click-testing fixes
- Fix link_to :method → button_to for all PUT/DELETE actions - Add button_to CSS reset to admin.css for visual consistency - Fix admin layout: replace broken jquery/jquery_ujs pipeline refs with admin_bundle via sprockets; add sprockets-rails, jquery-ui-rails gems - Add app/assets/javascripts/admin_bundle.js pipeline manifest - Fix event_information helper: use safe_join to avoid double-escaping - Fix nodes_helper: to_s(:db) → to_fs(:db) for event times - Fix revisions view: eliminate nested forms; diff button uses vanilla JS to collect radio button values before POST - Fix config/environments/development.rb and test.rb: cache_classes → enable_reloading - Add routing_filter_rails71_patch.rb version guard - Move LockedByAnotherUser to own file for Zeitwerk autoloading - Fix Globalize fallbacks via config.i18n.fallbacks in application.rb
Diffstat (limited to 'app/helpers')
-rw-r--r--app/helpers/link_helper.rb12
-rw-r--r--app/helpers/nodes_helper.rb16
2 files changed, 17 insertions, 11 deletions
diff --git a/app/helpers/link_helper.rb b/app/helpers/link_helper.rb
index cb13c8d..ea6c26f 100644
--- a/app/helpers/link_helper.rb
+++ b/app/helpers/link_helper.rb
@@ -39,11 +39,11 @@ module LinkHelper
39 end 39 end
40 40
41 def unlock_link 41 def unlock_link
42 message = "Are you sure you want to unlock?\n" + 42 message = "Are you sure you want to unlock?\n" \
43 "Locked by #{@node.lock_owner.login}\n" + 43 "Locked by #{@node.lock_owner.login}\n" \
44 "Last modified #{@page.updated_at.to_fs(:db)}" 44 "Last modified #{@page.updated_at.to_fs(:db)}"
45 45 button_to 'Unlock', unlock_node_path(@node),
46 link_to 'Unlock', unlock_node_path(@node), :method => :put, :data => { :confirm => message } 46 method: :put,
47 form: { data: { confirm: message } }
47 end 48 end
48
49end 49end
diff --git a/app/helpers/nodes_helper.rb b/app/helpers/nodes_helper.rb
index c739ccd..a054a2e 100644
--- a/app/helpers/nodes_helper.rb
+++ b/app/helpers/nodes_helper.rb
@@ -28,14 +28,20 @@ module NodesHelper
28 def user_list 28 def user_list
29 User.all.map {|u| [u.login, u.id]} 29 User.all.map {|u| [u.login, u.id]}
30 end 30 end
31 31
32 def event_information 32 def event_information
33 if @node.event 33 if @node.event
34 "#{@node.event.start_time.to_fs(:db)} - #{@node.event.end_time.to_fs(:db)} > " \ 34 safe_join([
35 "#{link_to 'show', event_path(@node.event)} " \ 35 "#{@node.event.start_time.to_fs(:db)} - #{@node.event.end_time.to_fs(:db)} > ",
36 "#{link_to 'edit', edit_event_path(@node.event)}" 36 link_to('show', event_path(@node.event)),
37 ' ',
38 link_to('edit', edit_event_path(@node.event))
39 ])
37 else 40 else
38 "no event attached > #{link_to 'add', new_event_path(:node_id => @node.id)}" 41 safe_join([
42 'no event attached > ',
43 link_to('add', new_event_path(:node_id => @node.id))
44 ])
39 end 45 end
40 end 46 end
41end 47end