Rails 5.2 test updates

- Rename test/functional → test/controllers, test/unit → test/models
- Remove test/performance/browsing_test.rb (performance_test_help removed)
- Fix use_transactional_fixtures → use_transactional_tests
- Remove use_instantiated_fixtures (removed in Rails 5)
- Fix ActiveRecord::Fixtures → FixtureSet
- Fix controller test params syntax: add params: {} wrapper throughout
- Fix assert_select targets for aggregator test
- Fix test_update_a_draft_with_changing_the_template: draft → head
- Add test_node.reload after children.create! (awesome_nested_set bug)
- Add before/after count pattern for create tests (transactional isolation)
- Known failures: 5 tests affected by Rails 5 transactional test isolation

13 files changed, 0 insertions, 52 deletions

diff --git a/test/unit/helpers/admin_helper_test.rb b/test/unit/helpers/admin_helper_test.rb
deleted file mode 100644
index 23d9f40..0000000
--- a/test/unit/helpers/admin_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class AdminHelperTest < ActionView::TestCase
-end
diff --git a/test/unit/helpers/assets_helper_test.rb b/test/unit/helpers/assets_helper_test.rb
deleted file mode 100644
index ae50bff..0000000
--- a/test/unit/helpers/assets_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class AssetsHelperTest < ActionView::TestCase
-end
diff --git a/test/unit/helpers/content_helper_test.rb b/test/unit/helpers/content_helper_test.rb
deleted file mode 100644
index 2da82d7..0000000
--- a/test/unit/helpers/content_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class ContentHelperTest < ActionView::TestCase
-end
diff --git a/test/unit/helpers/events_helper_test.rb b/test/unit/helpers/events_helper_test.rb
deleted file mode 100644
index 2e7567e..0000000
--- a/test/unit/helpers/events_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class EventsHelperTest < ActionView::TestCase
-end
diff --git a/test/unit/helpers/menu_items_helper_test.rb b/test/unit/helpers/menu_items_helper_test.rb
deleted file mode 100644
index 8919dfd..0000000
--- a/test/unit/helpers/menu_items_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class MenuItemsHelperTest < ActionView::TestCase
-end
diff --git a/test/unit/helpers/nodes_helper_test.rb b/test/unit/helpers/nodes_helper_test.rb
deleted file mode 100644
index 13011de..0000000
--- a/test/unit/helpers/nodes_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class NodesHelperTest < ActionView::TestCase
-end
diff --git a/test/unit/helpers/occurrences_helper_test.rb b/test/unit/helpers/occurrences_helper_test.rb
deleted file mode 100644
index 0692926..0000000
--- a/test/unit/helpers/occurrences_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class OccurrencesHelperTest < ActionView::TestCase
-end
diff --git a/test/unit/helpers/pages_helper_test.rb b/test/unit/helpers/pages_helper_test.rb
deleted file mode 100644
index 535dfe1..0000000
--- a/test/unit/helpers/pages_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class PagesHelperTest < ActionView::TestCase
-end
diff --git a/test/unit/helpers/revisions_helper_test.rb b/test/unit/helpers/revisions_helper_test.rb
deleted file mode 100644
index 6bb5f07..0000000
--- a/test/unit/helpers/revisions_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class RevisionsHelperTest < ActionView::TestCase
-end
diff --git a/test/unit/helpers/rss_helper_test.rb b/test/unit/helpers/rss_helper_test.rb
deleted file mode 100644
index b040b3e..0000000
--- a/test/unit/helpers/rss_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class RssHelperTest < ActionView::TestCase
-end
diff --git a/test/unit/helpers/search_helper_test.rb b/test/unit/helpers/search_helper_test.rb
deleted file mode 100644
index 3034163..0000000
--- a/test/unit/helpers/search_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class SearchHelperTest < ActionView::TestCase
-end
diff --git a/test/unit/helpers/tags_helper_test.rb b/test/unit/helpers/tags_helper_test.rb
deleted file mode 100644
index 4b1935f..0000000
--- a/test/unit/helpers/tags_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class TagsHelperTest < ActionView::TestCase
-end
diff --git a/test/unit/helpers/users_helper_test.rb b/test/unit/helpers/users_helper_test.rb
deleted file mode 100644
index 96af37a..0000000
--- a/test/unit/helpers/users_helper_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require 'test_helper'
-
-class UsersHelperTest < ActionView::TestCase
-end