summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--app/controllers/shared_previews_controller.rb16
-rw-r--r--test/controllers/shared_previews_controller_test.rb35
2 files changed, 45 insertions, 6 deletions
diff --git a/app/controllers/shared_previews_controller.rb b/app/controllers/shared_previews_controller.rb
index d482466..f6fb45a 100644
--- a/app/controllers/shared_previews_controller.rb
+++ b/app/controllers/shared_previews_controller.rb
@@ -3,13 +3,17 @@ class SharedPreviewsController < ApplicationController
3 @page = Page.find_by!(preview_token: params[:token]) 3 @page = Page.find_by!(preview_token: params[:token])
4 node = @page.node 4 node = @page.node
5 5
6 was_published = @page.published_at.present? 6 if node
7 superseded = was_published && node && node.head_id != @page.id 7 is_head = node.head_id == @page.id
8 currently_public = was_published && node && node.head_id == @page.id && @page.public? 8 is_draft = node.draft_id == @page.id
9 9
10 if superseded || currently_public 10 currently_public = is_head && @page.public?
11 redirect_to node_path(node) 11 superseded = !is_head && !is_draft
12 return 12
13 if superseded || currently_public
14 redirect_to @page.public_link
15 return
16 end
13 end 17 end
14 18
15 response.headers['X-Robots-Tag'] = 'noindex' 19 response.headers['X-Robots-Tag'] = 'noindex'
diff --git a/test/controllers/shared_previews_controller_test.rb b/test/controllers/shared_previews_controller_test.rb
new file mode 100644
index 0000000..5f2d20d
--- /dev/null
+++ b/test/controllers/shared_previews_controller_test.rb
@@ -0,0 +1,35 @@
1require 'test_helper'
2
3class SharedPreviewsControllerTest < ActionController::TestCase
4 test "renders the preview for a draft that is current but not yet head" do
5 node = Node.root.children.create!(:slug => "shared_preview_draft_test")
6 node.draft.ensure_preview_token!
7
8 get :show, params: { :token => node.draft.preview_token }
9
10 assert_response :success
11 end
12
13 test "renders the preview for a brand-new draft on an already-published node" do
14 node = Node.root.children.create!(:slug => "shared_preview_published_node_test")
15 node.publish_draft!
16 node.find_or_create_draft(User.first)
17 node.draft.ensure_preview_token!
18
19 get :show, params: { :token => node.draft.preview_token }
20
21 assert_response :success
22 end
23
24 test "redirects to the live page once the previewed draft has been published and become head" do
25 node = Node.root.children.create!(:slug => "shared_preview_now_head_test")
26 node.draft.ensure_preview_token!
27 token = node.draft.preview_token
28
29 node.publish_draft!
30
31 get :show, params: { :token => token }
32
33 assert_redirected_to node.head.public_link
34 end
35end