1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
|
require 'test_helper'
class NodesControllerTest < ActionController::TestCase
def test_get_index
Node.root.descendants.delete_all
test_node = Node.root.children.create :slug => "foo"
login_as :quentin
get :index
assert_response :success
end
def test_new
login_as :quentin
get :new
assert_response :success
end
test "create generic node with parent_id provided" do
login_as :quentin
before_count = Node.count
post(
:create,
params: {
:kind => "generic",
:parent_id => Node.root.id,
:title => "Hello Spaceboy"
}
)
assert_response :redirect
assert_equal before_count + 1, Node.count
assert_equal "hello-spaceboy", Node.last.slug
assert_equal Node.last.parent_id, Node.root.id
assert_equal 1, Node.last.level
end
test "create update node" do
login_as :quentin
post(
:create,
params: {
:kind => "update",
:title => "Hello Spaceboy"
}
)
assert_response :redirect
end
test "create top level node" do
login_as :quentin
before_count = Node.count
post(
:create,
params: {
:kind => "top_level",
:title => "Hello My Spaceboy"
}
)
assert_response :redirect
assert_equal before_count + 1, Node.count
expected = "hello-my-spaceboy"
assert_equal expected, Node.last.unique_name
assert_equal 1, Node.last.level
end
test "creating a top_level node without a title should not work" do
login_as :quentin
assert_no_difference "Node.count" do
post(:create, params: { :kind => "top_level" } )
end
end
test "creating a generic node without a parent_id should not work" do
login_as :quentin
assert_no_difference "Node.count" do
post(:create, params: { :kind => "generic" } )
end
end
test "editing a node" do
login_as :quentin
node = Node.find_by_unique_name("fourth_child")
node.pages.create
node.draft = node.pages.last
node.save
assert_equal 1, node.pages.length
draft = node.find_or_create_draft( User.first )
draft.title = "Hello"
draft.body = "World"
draft.save
node.publish_draft!
get :edit, params: { :id => node.id }
assert_response :success
assert_select("#page_title[value='Hello']")
assert_select("#page_body", "World")
node.reload
assert_equal 1, node.pages.length
assert_equal "Hello", node.find_or_create_draft( User.first ).title
assert_equal "World", node.find_or_create_draft( User.first ).body
end
test "editing a locked node raises LockedByAnotherUser Exception" do
login_as :quentin
node = create_node_with_draft
node.lock_owner = User.last
node.save
assert node.locked?
get :edit, params: { :id => node.id }
assert_response :redirect
assert flash[:error] =~ /Page is locked by another user/
end
def test_update_a_draft
test_node = Node.root.children.create! :slug => "test_node"
login_as :quentin
get :edit, params: { :id => test_node.id }
put :update, params: { :id => test_node.id, :page => {:title => "Hello", :body => "There"} }
test_node.reload
assert_equal "Hello", test_node.draft.title
assert_equal "There", test_node.draft.body
end
def test_update_a_draft_with_changing_the_template
test_node = Node.root.children.create! :slug => "test_node"
login_as :quentin
get :edit, params: { :id => test_node.id }
put :update, params: {
:id => test_node.id,
:page => {
:title => "Hello",
:body => "There",
:template_name => "Foobar"
}
}
put :publish, params: { :id => test_node.id }
test_node.reload
assert_equal "Hello", test_node.head.title
assert_equal "There", test_node.head.body
assert_equal "Foobar", test_node.head.template_name
end
test "publish draft with staged_slug unqueal slug" do
login_as :quentin
test_node = Node.root.children.create! :slug => "test_node", :staged_slug => "peter_pan"
put :publish, params: { :id => test_node.id }
test_node.reload
assert_equal "peter_pan", test_node.slug
assert_equal "peter_pan", test_node.unique_name
end
test "publish draft with staged_slug with more levels of nodes" do
login_as :quentin
test_node = Node.root.children.create! :slug => "test_node", :staged_slug => "peter_pan"
test_node2 = test_node.children.create! :slug => "test_node2"
put :publish, params: { :id => test_node.id }
test_node.reload; test_node2.reload
assert_equal "peter_pan/test_node2", test_node2.unique_name
assert_equal "peter_pan", test_node.unique_name
end
test "publish draft with staged_parent_id" do
login_as :quentin
parent = Node.root.children.create! :slug => "parent"
test_node = Node.root.children.create! :slug => "test_node", :staged_parent_id => parent.id
test_node2 = test_node.children.create! :slug => "test_node2"
put :publish, params: { :id => test_node.id }
test_node.reload; test_node2.reload
assert_equal "parent/test_node", test_node.unique_name
assert_equal "parent/test_node/test_node2", test_node2.unique_name
end
test "publish draft with staged_parent_id and staged_slug" do
login_as :quentin
parent = Node.root.children.create! :slug => "parent"
test_node = Node.root.children.create!(
:slug => "test_node",
:staged_parent_id => parent.id,
:staged_slug => "peter_pan"
)
test_node2 = test_node.children.create! :slug => "test_node2"
put :publish, params: { :id => test_node.id }
test_node.reload; test_node2.reload
assert_equal "parent/peter_pan", test_node.unique_name
assert_equal "parent/peter_pan/test_node2", test_node2.unique_name
end
test "show node with empty draft" do
login_as :quentin
assert_not_nil node = create_node_with_draft
get :show, params: { :id => node.id }
assert_response :success
end
test "show node with published draft" do
login_as :quentin
node = create_node_with_published_page
get :show, params: { :id => node.id }
assert_response :success
assert_select "div.node_content", :text => "Test", :count => 2
end
test "unlocking a locked node" do
login_as :quentin
node = create_node_with_published_page
node.find_or_create_draft User.first
assert node.locked?
put :unlock, params: { :id => node.id }
assert_response :redirect
assert !node.reload.locked?
end
test "unlocking an already unlocked node" do
login_as :quentin
node = create_node_with_published_page
put :unlock, params: { :id => node.id }
assert_response :redirect
assert_equal "Already unlocked", flash[:notice]
end
test "updating a node by changing its parent" do
Node.root.descendants.destroy_all
login_as :quentin
node = create_node_with_published_page
node.find_or_create_draft User.first
other_node = Node.root.children.create( :slug => "other" )
node.staged_parent_id = other_node.id
node.publish_draft!
assert Node.valid?
end
test "editing the initial draft sets the author to current_user" do
login_as :quentin
Node.root.descendants.destroy_all
node = create_node_with_draft
get :edit, params: { :id => node.id }
node.reload
assert_equal "quentin", node.draft.user.login
end
test "updating the author of a node with existing head" do
login_as :quentin
Node.root.descendants.destroy_all
node = create_node_with_published_page
assert_equal "quentin", node.head.user.login
node.find_or_create_draft users(:quentin)
assert node.draft.valid?
assert node.valid?
put :update, params: { :id => node.id, :page => {:user_id => users(:aaron).id} }
assert_response :redirect
assert_equal "aaron", node.reload.draft.user.login
end
test "updating an existing page should not modify published_at" do
login_as :quentin
Node.root.descendants.destroy_all
node = create_node_with_published_page
get :edit, params: { :id => node.id }
assert_response :success
put :update, params: { :id => node.id, :page => { :title => "updated" } }
put :publish, params: { :id => node.id }
node.reload
assert_equal node.pages[0].published_at, node.pages[1].published_at
end
test "updating an exisiting page should not alter the author" do
login_as :aaron
Node.root.descendants.destroy_all
node = create_node_with_published_page
get :edit, params: { :id => node.id }
put :update, params: { :id => node.id, :page => { :title => "updated" } }
put :publish, params: { :id => node.id }
node.reload
assert_equal node.pages[0].user, node.pages[1].user
end
test "editor and author are the same on a new node" do
login_as :quentin
node = create_node_with_draft
get :edit, params: { :id => node.id }
node.reload
assert_equal "quentin", node.draft.user.login
assert_equal "quentin", node.draft.editor.login
end
test "creating new draft alters the editor but keeps the author" do
node = create_node_with_published_page
assert_equal "quentin", node.head.user.login
login_as :aaron
get :edit, params: { :id => node.id }
put :update, params: { :id => node.id, :page => { :title => "updated" } }
node.reload
assert_equal "quentin", node.head.user.login
assert_equal "aaron", node.draft.editor.login
end
test "unlocking and relocking changes editor if done by another user" do
node = create_node_with_published_page
draft = node.find_or_create_draft users(:quentin)
assert_equal draft.user.login, draft.editor.login
assert node.locked?
node.unlock!
login_as :aaron
get :edit, params: { :id => node.id }
node.reload
assert_equal "quentin", node.draft.user.login
assert_equal "aaron", node.draft.editor.login
end
test "destroy a published node" do
node = create_node_with_published_page
node.destroy
login_as :quentin
get :index
assert_response :success
end
test "no dangling pages remain after node removal" do
node = create_node_with_published_page
page_id = node.pages.first.id
node.destroy
assert_raises(ActiveRecord::RecordNotFound) do
assert Page.find page_id
end
end
test "can remove a node with an event" do
node = create_node_with_published_page
event = Event.create!(
:start_time => "2009-01-01T15:23:42".to_time,
:end_time => "2009-01-01T20:05:23".to_time,
:url => "http://events.ccc.de/congress/2082",
:latitude => 52.525308,
:longitude => 13.378944,
:allday => true,
:node_id => node.id
)
event_id = event.id
assert_operator Occurrence.where(event_id: event_id).count, :>, 0, "expected the event to have generated at least one occurrence before destroy"
node.destroy
assert_equal 0, Occurrence.where(event_id: event_id).count
login_as :quentin
get :index
assert_response :success
end
test "show renders events row and add-link for zero-event chapter node" do
login_as :quentin
node = create_node_with_published_page
node.head.tag_list = "erfa-detail"
node.head.save!
get :show, params: { id: node.id }
assert_response :success
assert_select "a", text: "add event"
assert_select "a[href*='tag_list=open-day']"
assert_select "a[href*='auto_tag_source=erfa-detail']"
end
test "show renders events row without a tag default for untagged node" do
login_as :quentin
node = create_node_with_published_page
get :show, params: { id: node.id }
assert_response :success
assert_select "a", text: "add event"
assert_select "a[href*='tag_list=']", count: 0
end
test "show never renders a destroy link for events" do
login_as :quentin
node = create_node_with_published_page
Event.create!(node_id: node.id, start_time: Time.now, end_time: Time.now + 1.hour)
get :show, params: { id: node.id }
assert_response :success
assert_select "form.button_to.destructive", count: 0
end
test "reverting from nodes#show returns to the show page, not the editor, even if a draft remains" do
user = User.find_by_login("aaron")
node = Node.root.children.create!(:slug => "revert_return_to_test")
node.lock_for_editing!(user)
node.autosave!({:title => "v1"}, user)
node.save_draft!(user)
node.publish_draft!
node.lock_for_editing!(user)
node.autosave!({:title => "v2"}, user)
node.save_draft!(user)
node.lock_for_editing!(user)
node.autosave!({:title => "v3"}, user)
# state D: head, draft, and autosave all present, locked by aaron
login_as :aaron
put :revert, params: { :id => node.id, :return_to => node_path(node) }
assert_redirected_to node_path(node)
node.reload
assert node.draft.present?
assert node.autosave.blank?
end
test "reverting from nodes#edit without return_to still lands back in the editor when a draft remains" do
user = User.find_by_login("aaron")
node = Node.root.children.create!(:slug => "revert_default_test")
node.lock_for_editing!(user)
node.autosave!({:title => "v1"}, user)
node.save_draft!(user)
node.publish_draft!
node.lock_for_editing!(user)
node.autosave!({:title => "v2"}, user)
node.save_draft!(user)
node.lock_for_editing!(user)
node.autosave!({:title => "v3"}, user)
login_as :aaron
put :revert, params: { :id => node.id }
assert_redirected_to edit_node_path(node)
end
test "nodes#show does not offer to destroy the only draft of a never-published node" do
node = Node.root.children.create!(:slug => "draft_only_test")
login_as :quentin
get :show, params: { :id => node.id }
assert_response :success
assert_select "form.destructive", :count => 0
end
test "drafts includes a never-published node with only a draft" do
node = Node.root.children.create!(:slug => "drafts_action_test")
login_as :quentin
get :drafts
assert_includes assigns(:nodes), node
end
test "chapters filters by kind, matching head or draft, and shows both by default" do
erfa_node = Node.root.children.create!(:slug => "chapters_erfa_test")
erfa_node.find_or_create_draft(@user1)
erfa_node.draft.tag_list = "erfa-detail"
erfa_node.draft.save!
erfa_node.publish_draft!
chaostreff_node = Node.root.children.create!(:slug => "chapters_chaostreff_test")
chaostreff_node.find_or_create_draft(@user1)
chaostreff_node.draft.tag_list = "chaostreff-detail"
chaostreff_node.draft.save!
chaostreff_node.publish_draft!
login_as :quentin
get :chapters, params: { :kinds => "erfa" }
assert_includes assigns(:nodes), erfa_node
assert_not_includes assigns(:nodes), chaostreff_node
get :chapters
assert_includes assigns(:nodes), erfa_node
assert_includes assigns(:nodes), chaostreff_node
end
test "recent combined with a search term does not raise an ambiguous column error" do
login_as :quentin
get :recent, params: { :q => "Zombies" }
assert_response :success
end
test "drafts combined with a search term does not raise an ambiguous column error" do
login_as :quentin
get :drafts, params: { :q => "Zombies" }
assert_response :success
end
test "mine combined with a search term does not raise an ambiguous column error" do
login_as :quentin
get :mine, params: { :q => "Zombies" }
assert_response :success
end
test "mine shows each matching node only once, even with several revisions by the same user" do
login_as :quentin
user = User.find_by_login("quentin")
node = Node.root.children.create!(:slug => "dedup_test")
node.lock_for_editing!(user)
node.autosave!({:title => "v1"}, user)
node.save_draft!(user)
node.publish_draft!
node.lock_for_editing!(user)
node.autosave!({:title => "v2"}, user)
node.save_draft!(user)
node.publish_draft!
# three pages now exist on this node, all touched by quentin --
# without DISTINCT, the join would return this node three times
get :mine
matches = assigns(:nodes).select { |n| n.id == node.id }
assert_equal 1, matches.length
end
test "chapters combined with a search term does not raise an ambiguous column error" do
login_as :quentin
get :chapters, params: { :q => "Zombies" }
assert_response :success
end
test "tags path filters by an arbitrary raw tag, generalizing chapters" do
presse_node = Node.root.children.create!(:slug => "tags_path_presse_test")
presse_node.find_or_create_draft(@user1)
presse_node.draft.tag_list = "pressemitteilung"
presse_node.draft.save!
presse_node.publish_draft!
erfa_node = Node.root.children.create!(:slug => "tags_path_erfa_test")
erfa_node.find_or_create_draft(@user1)
erfa_node.draft.tag_list = "erfa-detail"
erfa_node.draft.save!
erfa_node.publish_draft!
login_as :quentin
get :tags, params: { :tags => "pressemitteilung" }
assert_includes assigns(:nodes), presse_node
assert_not_includes assigns(:nodes), erfa_node
assert_select "h1", "Nodes tagged: pressemitteilung"
assert_select "h1", :text => "Chapters", :count => 0
end
test "tags path with multiple tags matches any of them, not all" do
erfa_node = Node.root.children.create!(:slug => "tags_path_multi_erfa_test")
erfa_node.find_or_create_draft(@user1)
erfa_node.draft.tag_list = "erfa-detail"
erfa_node.draft.save!
erfa_node.publish_draft!
chaostreff_node = Node.root.children.create!(:slug => "tags_path_multi_chaostreff_test")
chaostreff_node.find_or_create_draft(@user1)
chaostreff_node.draft.tag_list = "chaostreff-detail"
chaostreff_node.draft.save!
chaostreff_node.publish_draft!
login_as :quentin
get :tags, params: {:tags => "erfa-detail,chaostreff-detail" }
assert_includes assigns(:nodes), erfa_node
assert_includes assigns(:nodes), chaostreff_node
end
test "chapters renders the curated heading" do
login_as :quentin
get :chapters
assert_select "h1", "Chapters"
end
test "sitemap collapses configured paths but leaves others open" do
club = Node.root.children.create!(:slug => "club")
erfas = club.children.create!(:slug => "erfas")
erfas.children.create!(:slug => "one_chapter")
other = Node.root.children.create!(:slug => "sitemap_controller_open_test")
other.children.create!(:slug => "sitemap_controller_open_child")
login_as :quentin
get :sitemap
assert_response :success
doc = Nokogiri::HTML::DocumentFragment.parse(response.body)
erfas_node_div = doc.css('.sitemap_node').find { |div| div.at_css('.field_hint')&.text&.include?(erfas.unique_name) }
other_node_div = doc.css('.sitemap_node').find { |div| div.at_css('.field_hint')&.text&.include?(other.unique_name) }
erfas_details = erfas_node_div.next_element
other_details = other_node_div.next_element
assert_equal 'details', erfas_details.name
assert_equal 'details', other_details.name
assert_not erfas_details.key?('open')
assert other_details.key?('open')
end
test "sitemap shows how many descendants a collapsed branch is hiding" do
club = Node.root.children.create!(:slug => "club")
erfas = club.children.create!(:slug => "erfas")
erfas.children.create!(:slug => "one_chapter")
erfas.children.create!(:slug => "another_chapter")
login_as :quentin
get :sitemap
assert_response :success
doc = Nokogiri::HTML::DocumentFragment.parse(response.body)
erfas_node_div = doc.css('.sitemap_node').find { |div| div.at_css('.field_hint')&.text&.include?(erfas.unique_name) }
erfas_details = erfas_node_div.next_element
assert_equal 'details', erfas_details.name
assert_match "2 descendants", erfas_details.at_css('summary').text
end
test "sitemap shows Show and Create Child, not Revisions" do
node = Node.root.children.create!(:slug => "sitemap_actions_test")
login_as :quentin
get :sitemap
assert_select ".sitemap_node_actions", :text => /Show/
assert_select ".sitemap_node_actions", :text => /Create Child/
assert_select ".sitemap_node_actions", :text => /Revisions/, :count => 0
end
end
|