1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
|
require 'test_helper'
class NodeTest < ActiveSupport::TestCase
def setup
@root = Node.find(1)
@first_child = Node.find(2)
@first_child.pages.create! :title => "one"
@first_child.draft = @first_child.pages.last
@first_child.save
@second_child = Node.find(3)
@second_child.pages.create! :title => "one"
@user1 = User.create :login => 'demo', :email => "f@b.com", :password => 'foobar', :password_confirmation => 'foobar'
@user2 = User.create :login => 'show', :email => "f@b.com", :password => 'foobar', :password_confirmation => 'foobar'
end
test "can only create one root node" do
Node.delete_all
Node.create! :slug => :root
assert_raise(ActiveRecord::RecordInvalid) do
Node.create! :slug => :root
end
end
def test_returning_existing_drafts
test_node = Node.root.children.create! :slug => "test_node"
assert_not_nil test_node.draft
assert_equal 1, test_node.pages.length
assert_nil test_node.draft.user
3.times do
test_node.find_or_create_draft @user1
end
assert_equal 1, test_node.pages.length
end
def test_user_gets_assigned_to_unlocked_draft
assert_not_nil @first_child.draft
assert_nil @first_child.draft.user
@first_child.find_or_create_draft @user1
assert_equal @user1, @first_child.lock_owner
end
def test_unique_path_returns_an_array
assert_equal ["first_child"], @first_child.unique_path
new_node = @first_child.children.create! :slug => "third_child"
assert_equal ["first_child", "third_child"], new_node.unique_path
end
def test_specifying_a_revision_other_than_with_a_fixnum_raises_exception
assert_raise(ArgumentError) { Node.find_page "first_child", 1.9 }
assert_raise(ArgumentError) { Node.find_page "first_child", "1" }
assert_raise(ArgumentError) { Node.find_page "first_child", :head }
end
def test_publish_draft_on_a_node_without_a_draft_returns_nil
assert @first_child.publish_draft!
assert_nil @first_child.publish_draft!
end
def test_cloning_a_head_page_to_a_new_draft_with_translations
assert_not_nil draft = @first_child.draft
I18n.locale = :de
draft.title = "Hallo"
draft.abstract = "Bitte"
draft.body = "Danke"
draft.save
I18n.locale = :en
draft.title = "Hello"
draft.abstract = "Please"
draft.body = "Thanks"
draft.save
@first_child.publish_draft!
draft1 = @first_child.find_or_create_draft(@user1)
I18n.locale = :de
assert_equal "Hallo", draft1.title
assert_equal "Bitte", draft1.abstract
assert_equal "Danke", draft1.body
I18n.locale = :en
assert_equal "Hello", draft1.title
assert_equal "Please", draft1.abstract
assert_equal "Thanks", draft1.body
end
def test_created_nodes_have_an_empty_draft_and_no_head
node = Node.root.children.create! :slug => "third_child_beta"
assert !node.pages.empty?
assert_equal 1, node.pages.length
assert_not_nil node.draft
assert_nil node.draft.user
assert_nil node.head
assert_nil node.autosave
end
def test_create_new_draft_of_published_page
node = Node.root.children.create :slug => "xyz"
assert node.publish_draft!
end
def test_find_or_create_draft_if_no_draft_exists
node = Node.root.children.create :slug => "xyz"
node.publish_draft!
assert_not_nil node.find_or_create_draft( @user1 )
end
def test_find_or_create_draft_if_draft_exists_and_is_owned_by_user
node = Node.root.children.create :slug => "xyz"
node.publish_draft!
first_call = node.find_or_create_draft @user1
second_call = node.find_or_create_draft @user1
assert_equal first_call, second_call
assert_equal 2, node.pages.count
assert_equal @user1, node.lock_owner
end
def test_exception_if_draft_exists_but_locked_by_another_user
node = Node.root.children.create :slug => "xyz"
node.publish_draft!
node.find_or_create_draft @user1
assert_equal @user1, node.lock_owner
assert_raise(LockedByAnotherUser) do
node.find_or_create_draft @user2
end
end
def test_creation_of_unique_name
node = Node.root.children.create :slug => 'child'
node.reload
assert_equal 'child', node.unique_name
node = @first_child.children.create :slug => 'deep_child'
node.reload
assert_equal 'first_child/deep_child', node.unique_name
end
def test_order_of_pages_by_revision
# This test should make sure the order is the same on different db's
# Remember, there is already an empty draft
two = @second_child.pages.create :title => "two"
three = @second_child.pages.create :title => "three"
four = @second_child.pages.create :title => "four"
@second_child.pages.reload
assert_equal [1,2,3,4], @second_child.pages.map { |x| x.revision }
end
def test_behavior_of_acts_as_list
two = @second_child.pages.create :title => "two"
three = @second_child.pages.create :title => "three"
four = @second_child.pages.create :title => "four"
assert_equal 2, two.revision
assert_equal 3, three.revision
assert_equal 4, four.revision
assert_equal four, @second_child.pages.last
assert two.move_to_bottom
two.reload; three.reload; four.reload;
assert_equal 4, two.revision
assert_equal 2, three.revision
assert_equal 3, four.revision
end
def test_retrieving_page_current
updates = Node.root.children.create(:slug => 'updates')
year = updates.children.create(:slug => '2008')
foo = year.children.create(:slug => 'foo')
assert_not_nil Node.find_by_unique_name('updates/2008/foo')
# Note that there is already an initial, blank revision
foo.pages.create :title => "Version 2"
foo.pages.create :title => "Version 3"
foo.pages.create :title => "Version 4"
foo.head = foo.pages.last
foo.save!
page = Node.find_page("updates/2008/foo")
assert_equal page, foo.pages.find_by_revision(4)
end
def test_retrieving_page_by_revision
updates = Node.root.children.create(:slug => 'updates')
year = updates.children.create(:slug => '2008')
foo = year.children.create(:slug => 'foo')
assert_not_nil Node.find_by_unique_name('updates/2008/foo')
# Note that there is already an initial, blank revision
foo.pages.create :title => "Version 2"
foo.pages.create :title => "Version 3"
foo.pages.create :title => "Version 4"
page = Node.find_page("updates/2008/foo", 2)
assert_equal "Version 2", page.title
end
# Thats a lengthy test to make sure everything works as it should, it was
# created during a bug hunt
def test_creating_new_draft
test_node = Node.root.children.create! :slug => "test_node"
test_node.draft.user = @user1
test_node.save
assert test_node.publish_draft!
test_node.reload
assert_equal 1, test_node.pages.length
assert_not_nil test_node.head
assert_nil test_node.draft
test_node.find_or_create_draft @user1
test_node.reload
assert_equal 2, test_node.pages.length
assert_not_nil test_node.draft
assert test_node.head != test_node.draft
end
test "restoring a revision" do
test_node = Node.root.children.create! :slug => "test_node"
create_revisions( test_node, 3 )
test_node.find_or_create_draft @user1
test_node.reload
assert_equal 4, test_node.pages.count
assert_equal 3, test_node.head.revision
test_node.restore_revision!(1)
assert_equal 1, test_node.head.revision
assert_equal 4, test_node.draft.revision
end
test "a new revision keeps the initial user" do
Node.root.descendants.destroy_all
node = create_node_with_draft
draft = node.draft
draft.user = users(:aaron)
draft.save
node.publish_draft!
new_draft = node.find_or_create_draft( users(:quentin) )
assert_equal "aaron", new_draft.user.login
end
test "a new revision can overwrite the initial author" do
Node.root.descendants.destroy_all
node = create_node_with_draft
draft = node.draft
draft.user = users(:aaron)
draft.save!
node.publish_draft!
new_draft = node.find_or_create_draft( users(:quentin) )
new_draft.user_id = users(:quentin).id
new_draft.save
node.publish_draft!
assert_equal "quentin", node.head.user.login
end
test "update?" do
Node.root.descendants.delete_all
updates = Node.root.children.create!( :slug => "updates" )
assert !updates.update?
updates2009 = updates.children.create!( :slug => "2009" )
assert !updates2009.update?
update = updates2009.children.create!( :slug => "my-first-update" )
assert update.update?
end
test "new nodes should have drafts with no publidhed_at set" do
node = Node.root.children.create( :slug => "wow" )
assert_nil node.draft.published_at
end
test "lock_for_editing! acquires the lock without creating a draft or autosave" do
node = create_node_with_published_page
node.lock_for_editing!(@user1)
assert_equal @user1, node.lock_owner
assert_nil node.draft
assert_nil node.autosave
end
test "autosave! creates a buffer that never appears among a node's pages, leaving the draft untouched" do
node = create_node_with_draft
node.lock_for_editing!(@user1)
page_count_before = node.pages.count
node.autosave!({ :title => "in progress" }, @user1)
node.reload
assert_not_nil node.autosave
assert_nil node.autosave.node_id
assert_equal page_count_before, node.pages.count
assert_not_equal "in progress", node.draft.title
end
test "save_draft! promotes an autosave into an existing draft without creating a new revision" do
node = create_node_with_draft
node.lock_for_editing!(@user1)
node.autosave!({ :title => "in progress" }, @user1)
page_count_before = node.pages.count
node.save_draft!(@user1)
node.reload
assert_nil node.autosave
assert_equal "in progress", node.draft.title
assert_equal page_count_before, node.pages.count
end
test "save_draft! promotes an autosave into a brand new, correctly-revisioned draft when none exists" do
node = create_node_with_published_page
head_revision = node.head.revision
node.lock_for_editing!(@user1)
node.autosave!({ :title => "updated version" }, @user1)
node.reload
assert_nil node.draft
assert_nil node.autosave.node_id
node.save_draft!(@user1)
node.reload
assert_not_nil node.draft
assert_equal head_revision + 1, node.draft.revision
assert_equal head_revision, node.head.revision
assert_nil node.autosave
assert_equal 2, node.pages.count
assert_equal node.head.user, node.draft.user
assert_equal @user1, node.draft.editor
assert_equal node.head.published_at, node.draft.published_at
end
test "autosave!, save_draft!, and lock_for_editing! raise LockedByAnotherUser for a second user" do
node = create_node_with_published_page
node.lock_for_editing!(@user1)
assert_raise(LockedByAnotherUser) { node.autosave!({ :title => "x" }, @user2) }
assert_raise(LockedByAnotherUser) { node.save_draft!(@user2) }
assert_raise(LockedByAnotherUser) { node.lock_for_editing!(@user2) }
assert_equal @user1, node.reload.lock_owner
end
test "wipe_draft! leaves a fresh autosave and its lock untouched" do
node = create_node_with_published_page
node.lock_for_editing!(@user1)
node.autosave!({ :title => "still typing" }, @user1)
node.wipe_draft!
node.reload
assert_not_nil node.autosave
assert_equal @user1, node.lock_owner
end
test "wipe_draft! destroys a stale, orphaned autosave and releases its lock" do
node = create_node_with_published_page
node.lock_for_editing!(@user1)
node.autosave!({ :title => "abandoned mid-session" }, @user1)
node.autosave.update_column(:updated_at, 2.days.ago)
node.wipe_draft!
node.reload
assert_nil node.autosave
assert_nil node.lock_owner
end
test "revert! is a safe no-op on a fresh node with only a draft" do
node = create_node_with_draft
node.lock_for_editing!(@user1)
node.revert!(@user1)
node.reload
assert_not_nil node.draft
assert_equal @user1, node.lock_owner
end
test "revert! discards an autosave on a fresh node without touching its only draft" do
node = create_node_with_draft
node.lock_for_editing!(@user1)
node.autosave!({ :title => "typing" }, @user1)
node.revert!(@user1)
node.reload
assert_nil node.autosave
assert_not_nil node.draft
assert_equal @user1, node.lock_owner
end
test "revert! does nothing when a published node has no draft or autosave" do
node = create_node_with_published_page
node.lock_for_editing!(@user1)
node.revert!(@user1)
node.reload
assert_not_nil node.head
assert_nil node.draft
end
test "revert! discards a fresh autosave and releases the lock when no draft exists" do
node = create_node_with_published_page
node.lock_for_editing!(@user1)
node.autosave!({ :title => "in progress" }, @user1)
node.revert!(@user1)
node.reload
assert_nil node.autosave
assert_nil node.draft
assert_nil node.lock_owner
end
test "revert! destroys an existing draft and releases the lock" do
node = create_node_with_published_page
head_title = node.head.title
node.lock_for_editing!(@user1)
node.autosave!({ :title => "second version" }, @user1)
node.save_draft!(@user1)
node.revert!(@user1)
node.reload
assert_nil node.draft
assert_equal head_title, node.head.title
assert_nil node.lock_owner
end
test "revert! discards only the autosave when a draft survives beneath it" do
node = create_node_with_published_page
node.lock_for_editing!(@user1)
node.autosave!({ :title => "second version" }, @user1)
node.save_draft!(@user1)
node.autosave!({ :title => "third version, still typing" }, @user1)
node.revert!(@user1)
node.reload
assert_nil node.autosave
assert_not_nil node.draft
assert_equal "second version", node.draft.title
assert_equal @user1, node.lock_owner
end
test "revert! raises LockedByAnotherUser for a non-owner" do
node = create_node_with_published_page
node.lock_for_editing!(@user1)
assert_raise(LockedByAnotherUser) { node.revert!(@user2) }
assert_equal @user1, node.reload.lock_owner
end
def create_revisions node, count
count.times do
node.find_or_create_draft @user1
node.publish_draft!
end
end
test "available_layer_pairs matches the six-state table" do
node = Node.root.children.create!(:slug => "layer_pairs_test")
user = @user1 || User.find_by_login("aaron")
assert_equal [[:draft, :autosave]], (node.lock_for_editing!(user); node.autosave!({title: "v1"}, user); node.available_layer_pairs) # state F
node.save_draft!(user)
node.publish_draft!
assert_equal [], node.available_layer_pairs # state A
node.lock_for_editing!(user)
node.autosave!({title: "v2"}, user)
assert_equal [[:head, :autosave]], node.available_layer_pairs # state B
node.save_draft!(user)
assert_equal [[:head, :draft]], node.available_layer_pairs # state C
node.lock_for_editing!(user)
node.autosave!({title: "v3"}, user)
assert_equal [[:head, :draft], [:draft, :autosave]], node.available_layer_pairs # state D
end
test "publishing a staged move under one's own descendant is rejected, not allowed to crash" do
a = Node.root.children.create!(:slug => "cycle_guard_a")
b = a.children.create!(:slug => "cycle_guard_b")
a.staged_parent_id = b.id
assert_raises(ActiveRecord::RecordInvalid) { a.publish_draft! }
a.reload
assert_equal Node.root.id, a.parent_id
end
test "editor_search matches a partial substring, not just a whole word" do
node = Node.root.children.create!(:slug => "editor_search_substring_test")
node.find_or_create_draft(@user1)
node.draft.update(:title => "Biometrics Conference")
node.publish_draft!
assert_includes Node.editor_search("bio"), node
assert_includes Node.editor_search("Conf"), node
end
test "editor_search returns an empty relation for a blank term, not every node" do
assert_equal 0, Node.editor_search("").count
assert_equal 0, Node.editor_search(nil).count
assert_equal 0, Node.editor_search(" ").count
end
test "editor_search requires every word to match, but each word can match a different field" do
node = Node.root.children.create!(:slug => "editor_search_multiword_test")
node.find_or_create_draft(@user1)
node.draft.update(:title => "Backspace e.V. Bamberg", :abstract => "Spiegelgraben 41, 96052 Bamberg")
node.publish_draft!
assert_includes Node.editor_search("Backspace Spiegelgraben"), node
assert_equal 0, Node.editor_search("Backspace Nonexistentstreet").count
end
test "drafts_and_autosaves without a user sorts by recency only" do
older = Node.root.children.create!(:slug => "drafts_order_older")
older.find_or_create_draft(@user1)
newer = Node.root.children.create!(:slug => "drafts_order_newer")
newer.find_or_create_draft(@user1)
result = Node.drafts_and_autosaves.to_a
assert result.index(newer) < result.index(older)
end
test "drafts_and_autosaves with a user puts their own locked nodes first, regardless of recency" do
mine = Node.root.children.create!(:slug => "drafts_order_mine")
mine.lock_for_editing!(@user1)
mine.autosave!({:title => "mine"}, @user1)
someone_elses_newer = Node.root.children.create!(:slug => "drafts_order_theirs")
other_user = User.find_by_login("quentin")
someone_elses_newer.lock_for_editing!(other_user)
someone_elses_newer.autosave!({:title => "theirs"}, other_user)
result = Node.drafts_and_autosaves(current_user_id: @user1.id).to_a
assert result.index(mine) < result.index(someone_elses_newer)
end
test "recently_changed includes a node whose head was recently published" do
node = Node.root.children.create!(:slug => "recent_changed_published")
node.find_or_create_draft(@user1)
node.autosave!({:title => "v1"}, @user1)
node.save_draft!(@user1)
node.publish_draft!
assert_includes Node.recently_changed, node
end
test "recently_changed excludes a node only touched by locking or unlocking after an old publish" do
node = Node.root.children.create!(:slug => "recent_changed_lock_only")
node.find_or_create_draft(@user1)
node.autosave!({:title => "v1"}, @user1)
node.save_draft!(@user1)
node.publish_draft!
node.head.update_column(:updated_at, 20.days.ago)
node.lock_for_editing!(@user1)
node.unlock!
assert_not_includes Node.recently_changed, node
end
end
|